-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
after reconnecting, store does not resume sync #133
Comments
Hi I went through the code as well as the APIs of this issue. As you mentioned above that the event is not called 'connect' but 'reconnect' and there are only 3 events declared in the hoodie-connection-status which are 'disconnect, reconnect and reset'. There is no event named 'connect'. So I guess if we just change 'connect' to 'reconnect', would it solve the issue ? |
@Alice-anjali yes, I think so. It might break some tests so these will need to be fixed, too. And if the change does not break any tests, then we should probably add a test for it :) Do you want to give a try? |
Yes I would definitely give it a try! ^_^ |
I changed 'connect' to 'reconnect' and checked it. There are no tests breaking. @sohini-roy is already writing related test cases in the coverage issue. So, can I make a PR for this? |
Yes, please :) If you run into any blockers with the tests, let’s discuss there |
I made a PR, please review it. :-) |
The problem is in this line:
https://github.com/hoodiehq/hoodie-client/blob/master/lib/init.js#L72
The event is not called
connect
butreconnect
, see https://github.com/hoodiehq/hoodie-connection-status#eventsThe text was updated successfully, but these errors were encountered: