Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add localVisualizations for quick links to Honeycomb traces in dev #69

Closed
JamieDanielson opened this issue Feb 12, 2024 · 0 comments · Fixed by #81
Closed

[feat] Add localVisualizations for quick links to Honeycomb traces in dev #69

JamieDanielson opened this issue Feb 12, 2024 · 0 comments · Fixed by #81
Assignees
@JamieDanielson
Labels
type: enhancement New feature or request
Milestone
Beta

Comments

@JamieDanielson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When working in dev it can be helpful to quickly see the trace created with a link to a trace in Honeycomb.

Describe the solution you'd like

For each trace created, print a link to the console so that you can click to find it in Honeycomb... similar to what we have in the node distro.

Describe alternatives you've considered

Maybe a different name or configuration for this?

Additional context

This is listed already in our SDK Configuration and has some parts built but commented out in the repo already.
@JamieDanielson JamieDanielson added the type: enhancement New feature or request label Feb 12, 2024
@JamieDanielson JamieDanielson added this to the Beta milestone Feb 12, 2024
@JamieDanielson JamieDanielson self-assigned this Feb 15, 2024
@JamieDanielson JamieDanielson mentioned this issue Feb 16, 2024
Merged
JamieDanielson added a commit that referenced this issue Feb 16, 2024
@JamieDanielson
feat: add localVisualizations for link to Honeycomb trace (#81)
1d61d5e 
## Which problem is this PR solving?

- Closes #69 

## Short description of the changes

- Add `ConsoleTraceLinkExporter` that logs in the console a direct link
to a trace in Honeycomb
- Add `CompositeExporter` to allow for configuring multiple exporters,
which is necessary for using both our regular OTLP exporter (to
Honeycomb) and this console exporter
- Update the span processor builder to allow for both the
`ConsoleTraceLinkExporter` and a user-provided exporter, such as a
regular `ConsoleSpanExporter`
- Update README for this option and others recently added

## How to verify that this has the expected result

Update example app to include `localVisualizations: true` and click the
link in the console to be brought directly to a trace in Honeycomb
![honeycomb link to
trace](https://github.com/honeycombio/honeycomb-opentelemetry-web/assets/29520003/aaf98a70-e56e-4e55-9b0c-96979849b920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieDanielson JamieDanielson

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

feat: add localVisualizations for link to Honeycomb trace honeycombio/honeycomb-opentelemetry-web
1 participant
@JamieDanielson