[feat] Add skipOptionsValidation or similar for silencing warnings #68
Comments
pkanal
added a commit
that referenced
this issue
Feb 16, 2024
## Which problem is this PR solving? - Closes #68 Adds validation warnings for options. Adds `skipOptionsValidation` option to config. This option is used when sending directly to a collector so warnings for not providing an `apiKey` can be suppressed. ## Short description of the changes - Warns if there is an `apiKey` missing - Warns if there is a `serviceName` missing - Warns if a `dataset` is provided but the `apiKey` is a E&S key and a `serviceName is provided - Warns if `dataset` is missing if a Classic `apiKey` is provided - Warns if `sampler` has been overridden - Adds `skipOptionsValidation` option that doesn't show any of these warnings if set to `true`, set to `false` by default ## How to verify that this has the expected result - Run the example app and don't provide an `apiKey`, you should see the `apiKey` warning and so forth - Run the example app and set `skipOptionsValidation` to `true`, you should see the skip options validation message and no other warnings - Tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When sending to an OpenTelemetry Collector, you don't want the apiKey in the config because it's in the collector config. However, we emit warnings when an API Key is missing from the config.
Describe the solution you'd like
We can add the
skipOptionsValidationconfig option to silence these warnings, similar to what we have in the node distro.Describe alternatives you've considered
Maybe a better name or configuration for this?
Additional context
This is listed already in our SDK Configuration and has some parts built but commented out in the repo already.
The text was updated successfully, but these errors were encountered: