Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset header causes warning in console #27

Closed
JamieDanielson opened this issue Jan 22, 2024 · 2 comments
Closed

dataset header causes warning in console #27

JamieDanielson opened this issue Jan 22, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@JamieDanielson
Copy link
Contributor

Versions

main as of commit 55dddd3

Steps to reproduce

  1. add API key and run example
  2. see warning in console "http-json-trace-exporter.js:16 Header "x-honeycomb-dataset" has wrong value and will be ignored"

Additional context

dataset header should only get set if needed. looks like we set the header key in the exporter, and leave the value undefined if not classic... but even without a value the key is there so we get a console warning.

This is a nuisance issue, not a big deal but should be updated

@JamieDanielson JamieDanielson added the type: bug Something isn't working label Jan 22, 2024
@JamieDanielson
Copy link
Contributor Author

Never mind I think I had an old version at the time, this isn't a current issue.

@JamieDanielson
Copy link
Contributor Author

Reopening, I think there's still an issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant