Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Connect smoke tests to CI #17

Closed
pkanal opened this issue Jan 2, 2024 · 0 comments · Fixed by #55
Closed

[ci] Connect smoke tests to CI #17

pkanal opened this issue Jan 2, 2024 · 0 comments · Fixed by #55
Assignees
@JamieDanielson
Labels
type: maintenance The necessary chores to keep the dust off.
Milestone
Beta

Comments

@pkanal
Copy link
Contributor

pkanal commented Jan 2, 2024

Connect cypress tests to CI
@pkanal pkanal added type: enhancement New feature or request type: maintenance The necessary chores to keep the dust off. and removed type: enhancement New feature or request labels Jan 2, 2024
@pkanal pkanal added this to the Beta milestone Jan 2, 2024
@JamieDanielson JamieDanielson mentioned this issue Jan 26, 2024
Merged
JamieDanielson added a commit that referenced this issue Jan 29, 2024
@JamieDanielson
maint: add mini smoke test to CI (#50)
16579c4 
## Which problem is this PR solving?

- ensure apps build properly on every commit

## Short description of the changes

- add mini smoke test to CI that just ensures the app can build and run
without error

## How to verify that this has the expected result

run these locally and it should build fine, change the
auto-instrumentations-web version to 0.35 and see it error. Actually we
should see this fail in dependabots too until the fix comes out for
auto-instrumentations.

Note this is a temporary stopgap to catch errors before we finish
implementing #17
@JamieDanielson JamieDanielson mentioned this issue Jan 29, 2024
Merged
@JamieDanielson JamieDanielson self-assigned this Jan 29, 2024
JamieDanielson added a commit that referenced this issue Jan 30, 2024
@JamieDanielson
maint: build out smoke tests and connect to CI (#55)
3a64643 
## Which problem is this PR solving?

- Closes #17 

## Short description of the changes

- Add smoke tests using BATS, similar to our other distros. This
primarily allows for re-using smoke test logic independent of language,
as it inspects and asserts against telemetry collected by the Collector
and exported to a file.
- Update CircleCI config to run smoke tests in every push, similar to
lint/build/test
- Add Makefile for easier smoke testing. This doesn't appear to be
necessary for local smoke testing, as similar scripts in the
`package.json` also work locally. CI didn't seem to work as well, hence
the decision to keep the Makefile.
- Update `DEVELOPING.md` with some details around smoke tests
- Update example to send to collector at localhost, without API key.
This may be the most "controversial" and may warrant having a different
example app - open to ideas. If we keep an API key we have end up with
CORS errors for a "With-Credentials" header.

## How to verify that this has the expected result

See the [results in
Circle](https://app.circleci.com/pipelines/github/honeycombio/honeycomb-opentelemetry-web/113/workflows/546edcba-4d22-4dd9-8fc3-114170373f0f/jobs/435/artifacts),
including actual assertions like `Agent includes browser attributes` as
well as telemetry output stored from the collector file export.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieDanielson JamieDanielson

Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

maint: build out smoke tests and connect to CI honeycombio/honeycomb-opentelemetry-web
2 participants
@pkanal @JamieDanielson