You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There a number of @opentelemetry packages in the package.json of this package. However, they are called in the code that is unbundled. If they are expected to be provided by the consumer, then these should be specified as peerDependencies. https://pnpm.io/how-peers-are-resolved
This prevents version duplication as well as forces the end user to specify what version they are on.
The text was updated successfully, but these errors were encountered:
We've taken a look at this and all of the open telemetry libraries are core dependencies that are part of the bundle. The only one we could look at removing (not moving to peer) is @opentelemetry/auto-instrumentations-web but it is complicated as we do include that in the CDN distribution that we build.
We will keep an eye out in the future on our dependencies and if we can remove/move any of them. Thanks for raising this
honeycomb-opentelemetry-web/package.json
Lines 39 to 53 in e46248c
There a number of
@opentelemetry
packages in the package.json of this package. However, they are called in the code that is unbundled. If they are expected to be provided by the consumer, then these should be specified aspeerDependencies
. https://pnpm.io/how-peers-are-resolvedThis prevents version duplication as well as forces the end user to specify what version they are on.
The text was updated successfully, but these errors were encountered: