Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable warning #660

Open
mperham opened this issue Jan 18, 2025 · 1 comment
Open

Unused variable warning #660

mperham opened this issue Jan 18, 2025 · 1 comment

Comments

@mperham
Copy link

mperham commented Jan 18, 2025

honeybadger-5.26.2/lib/honeybadger/backtrace.rb:124: warning: assigned but unused variable - instance

I've seen Honeybadger ship a number of gem versions with unused variable warnings. Do you guys have Ruby warnings logged by default? Would you consider integrating a linter like standard to auto-format and auto-fix minor issues like this? Sidekiq has been using standard for many years and it's been fantastic.

@stympy
Copy link
Member

stympy commented Jan 20, 2025

Yup, we'd merge a PR that added Standard and updated the code to pass its checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants