Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved contrast between selected and deselected controls on modal #2343

Open
justjam2013 opened this issue Feb 4, 2025 · 2 comments
Open

Comments

@justjam2013
Copy link
Contributor

Feature Description

I think that this more intuitive but from a personal preference, I think the color is not ... "exploring the space".

Image

Maybe something like this? There is more color in the popup, but all that green ... it feels like there should be some cows somewhere 🐄 😂

Maybe the buttons should be the theme color, like on the Settings screen?

Image

And those two shades of gray are a little bit ambiguous

Image

@justjam2013
Copy link
Contributor Author

So ... I just went down the rabbit hole but found these very interesting articles on toggles:
What Makes A Great Toggle Button? (Case Study, Part 1)
What Makes A Great Toggle Button? (Case Study, Part 2)

My favorite was this one, although the right side text (the unselected toggle) should be lighter than black. The toggle colors would match the theme.

Image

This was my second choice although again the right side text (the unselected toggle) should be lighter than black.

Image

@justjam2013
Copy link
Contributor Author

Some mockups from the buttons above.

The colors would match the theme, so similar to the original but with the black replaced with a lighter shade and grayed text. My only concern with this is that it may be a little overpowering with the stronger colors:

Image

This variation on the current popup is not bad. Maybe the current popup is actually fine with just a little extra contrast between selected and deselected buttons:

Image

And this bleak, institutional white maybe:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant