Avoid early DNS plug-in start

A connectivity check can potentially be triggered before the DNS
plug-in is loaded. Avoid calling restart on the DNS plug-in before
it got initiially loaded. This prevents starting before attaching.
The attaching makes sure that the DNS plug-in container is recreated
before the DNS plug-in is initially started, which is e.g. needed
by a potentially hassio network configuration change (e.g. the
migration required to enable/disable IPv6 on the hassio network,
see #5879).

Author: agners

supervisor/host/network.py

@@ -158,6 +158,7 @@ async def _check_connectivity_changed(
             DBUS_ATTR_PRIMARY_CONNECTION in changed
             and changed[DBUS_ATTR_PRIMARY_CONNECTION]
             and changed[DBUS_ATTR_PRIMARY_CONNECTION] != DBUS_OBJECT_BASE
+            and await self.sys_plugins.dns.is_running()
         ):
             await self.sys_plugins.dns.restart()
 

supervisor/plugins/dns.py

@@ -211,7 +211,7 @@ async def restart(self) -> None:
         try:
             await self.instance.restart()
         except DockerError as err:
-            raise CoreDNSError("Can't start CoreDNS plugin", _LOGGER.error) from err
+            raise CoreDNSError("Can't restart CoreDNS plugin", _LOGGER.error) from err
 
     async def start(self) -> None:
         """Run CoreDNS."""