Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelWidgets Icons are unintuitive; update icons and/or add tooltips #38

Open
ahuang11 opened this issue Oct 6, 2023 · 2 comments
Open

Comments

@ahuang11
Copy link
Contributor

ahuang11 commented Oct 6, 2023

Initially, I thought checkmark == annotator.commit but it's actually add_annotation; the triangle is actually commit.

I haven't looked closely at the code, but if they're tabler icons, I suggest using one of these upload icons, and also perhaps add a tooltip icon next to them.
image

image
import pandas as pd
import holoviews as hv
from holonote.annotate import Annotator, SQLiteDB
from holonote.app import PanelWidgets
import geoviews as gv
import panel as pn

gv.extension("bokeh")


conn = SQLiteDB(filename=":memory:")
annotator = Annotator(
    {"x": int},
    fields=["description"],
    connector=conn,
)

widgets = PanelWidgets(annotator)
df = pd.DataFrame([[1, 2], [3, 4], [5, 6]], columns=["x", "y"])

pn.Row(
    pn.Row(widgets, pn.indicators.TooltipIcon(value="Check == adds description")),
    hv.Curve(df, kdims=["x"], vdims=["y"]) * annotator,
)
@ahuang11 ahuang11 changed the title PanelWidgets Icons are unintuitive PanelWidgets Icons are unintuitive; update icons and/or add tooltips Oct 6, 2023
@ahuang11
Copy link
Contributor Author

This might be implemented on the Bokeh level.

@hoxbro
Copy link
Member

hoxbro commented Nov 13, 2023

I have added a description to the buttons in #54 for now to soften the unintuitiveness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants