Skip to content

Commit 8d13330

Browse files
committed
Fix QA warnings
#132
1 parent 7aa0144 commit 8d13330

4 files changed

Lines changed: 22 additions & 32 deletions

File tree

input/fsh/models/pss.fsh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
Logical: PSSRequest
22
Id: PSSRequest
33
Title: "PSS Request"
4-
Description: "A request for PSS (Prescriber Support System) results."
4+
Description: "Request for PSS (Prescriber Support System) results."
55
* recordedDate 1..1 date "Date on which the information was recorded"
6-
* PSSID 1..1 Identifier "Identifier of the exchange session"
6+
* pssID 1..1 Identifier "Identifier of the exchange session"
77
* examination 0..1 Reference "The ID of the examination the prescriber wants to prescribe"
88
* indication 1..* CodeableConcept "Indication that triggers the PSS request, from structured list or free text"
99
* supportingInfo 1..1 BackboneElement "Information useful for PSS proposals"
@@ -14,9 +14,9 @@ Description: "A request for PSS (Prescriber Support System) results."
1414
Logical: PSSResponse
1515
Id: PSSResponse
1616
Title: "PSS Response"
17-
Description: "A response containing the results from the PSS."
17+
Description: "Response containing the results from the PSS."
1818
* recordedDate 1..1 date "Date on which the information was recorded"
19-
* PSSID 1..1 Identifier "Identifier of the exchange session"
19+
* pssID 1..1 Identifier "Identifier of the exchange session"
2020
* indication 1..1 CodeableConcept "Condition that triggered the PSS response"
2121
* status 1..1 CodeableConcept "Status of the response"
2222
* treatmentOptions 1..* BackboneElement "List of search results provided by PSS"
@@ -35,7 +35,7 @@ Id: PSSFeedbackModel
3535
Title: "PSS Feedback"
3636
Description: "Feedback containing the acceptance of the PSS results."
3737

38-
* PSSID 1..1 string "The uuid from the response - the ID of the RequestGroup"
38+
* pssID 1..1 string "The uuid from the response - the ID of the RequestGroup"
3939
* outcomeTimeStamp 1..1 dateTime "The time when the feedback is given"
4040
* outcome 1..1 code "accepted, rejected, overridden"
4141
* suggestionOutcome 0..* BackboneElement "List of suggestions provided by PSS for which feedback is given"
@@ -56,7 +56,7 @@ Id: PSSConsentModel
5656
Title: "PSS Consent"
5757
Description: "Consent statement about using PSS and agreeing with (or opting out of) the Terms and Conditions."
5858

59-
* HCPID 1..1 string "The anonymised ID of the healthcare professional"
59+
* hcpID 1..1 string "The anonymised ID of the healthcare professional"
6060
* recordedDate 1..1 date "Date on which the information was recorded"
6161
* instruction 1..1 string "The instruction to the HCP"
6262
* termsConditions 1..1 BackboneElement "Terms and Conditions"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
ValueSet: PSSFeedbackCodesVS
22
Title: "PSS Feedback Codes"
33
Description: "Feedback codes for PSS"
4+
* ^experimental = true
45
* codes from system PSSFeedbackCodes
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
ValueSet: PSSFeedbackReasonsVS
22
Title: "PSS Feedback Code Reasons"
33
Description: "Feedback code reasons for PSS"
4+
* ^experimental = true
45
* codes from system PSSaFeedbackReasons
56
* codes from system PSSrFeedbackReasons

input/ignoreWarnings.txt

Lines changed: 14 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,34 @@
66
# PSSDataAcquisitionForm does not use the answerOption[responseImage] slice of CPGComputableQuestionnaire
77
This element does not match any known slice defined in the profile https://www.ehealth.fgov.be/standards/fhir/pss/StructureDefinition/PSSDataAcquisitionForm|1.0.0 (this may not be a problem, but you should check that it's not intended to match a slice)
88

9-
10-
# Several examples use fictitious, unavailable or not-yet existing code systems
11-
A definition for CodeSystem 'https://www.ehealth.fgov.be/standards/fhir/medication/CodeSystem/vmpg' could not be found, so the code cannot be validated
12-
139
# Several examples use fictitious, unavailable or not-yet existing code systems
1410
A code with no system has no defined meaning, and it cannot be validated. A system should be provided
1511

1612

1713
# External URLs are not relevant
1814
URL value 'https://bcfi.be/nl/chapters/12?frag=8001869' does not resolve
15+
No definition could be found for URL value 'https://bcfi.be/nl/chapters/12?frag=8001869'
1916

2017
# External URLs are not relevant
2118
URL value 'https://cbip.be/fr/chapters/12?frag=8001869' does not resolve
19+
No definition could be found for URL value 'https://cbip.be/fr/chapters/12?frag=8001869'
20+
2221

2322
# External URLs are not relevant
2423
URL value 'https://ebpnet.be/nl/pss-vaginitis' does not resolve
24+
No definition could be found for URL value 'https://ebpnet.be/nl/pss-vaginitis'
25+
No definition could be found for URL value 'https://ebpnet.be/fr/pss-vaginite'
2526

2627
# External URLs are not relevant
2728
URL value 'https://ebpnet.be/fr/pss-vaginite' does not resolve
29+
No definition could be found for URL value 'https://cbip.be/fr/chapters/12?frag=8001869'
30+
31+
# External URLs are not relevant
32+
URL value 'https://environment.esriguide.org/suportingContent/12345' does not resolve
33+
No definition could be found for URL value 'https://environment.esriguide.org/suportingContent/12345'
2834

35+
# Some resources will not get narratives
36+
Constraint failed: dom-6: 'A resource should have narrative for robust management (text.`div`.exists())' (defined in http://hl7.org/fhir/StructureDefinition/DomainResource) (Best Practice Recommendation)
2937

3038
# Several examples use fictitious, unavailable or not-yet existing code systems
3139
A definition for CodeSystem 'https://www.ehealth.fgov.be/standards/fhir/pss/CodeSystem/PSSQSIConditions' could not be found, so the code cannot be validated
@@ -41,30 +49,10 @@ A definition for CodeSystem 'https://www.ehealth.fgov.be/standards/fhir/medicati
4149
URL value 'https://www.ehealth.fgov.be/standards/fhir/medication/CodeSystem/vmpg' does not resolve
4250

4351

44-
# External URLs are not relevant
45-
URL value 'https://bcfi.be/nl/chapters/12?frag=8001869' does not resolve
46-
47-
# External URLs are not relevant
48-
URL value 'https://cbip.be/fr/chapters/12?frag=8001869' does not resolve
49-
50-
# External URLs are not relevant
51-
URL value 'https://ebpnet.be/nl/pss-vaginitis' does not resolve
52-
53-
# External URLs are not relevant
54-
URL value 'https://ebpnet.be/fr/pss-vaginite' does not resolve
55-
56-
# External URLs are not relevant
57-
URL value 'https://ebpnet.be/nl/pss-vaginitis' does not resolve
58-
59-
# External URLs are not relevant
60-
URL value 'https://ebpnet.be/fr/pss-vaginite' does not resolve
61-
62-
# External URLs are not relevant
63-
URL value 'https://environment.esriguide.org/suportingContent/12345' does not resolve
64-
6552

6653
# At the moment, the Radiology examples contain Observations - see issue 102
6754
Best Practice Recommendation: In general, all observations should have a performer
6855

6956
# The extension AnswerOptionAdditionalCode has several uses, but not used in the current examples
70-
The Implementation Guide contains no examples for this extension
57+
The Implementation Guide contains no examples for this extension
58+

0 commit comments

Comments
 (0)