fix(rosetta): use /v2/fees/transaction for fee estimation

Author: zone117x

package-lock.json

@@ -91,10 +91,10 @@
     "@promster/types": "3.2.3",
     "@scure/base": "1.1.1",
     "@sinclair/typebox": "0.31.28",
-    "@stacks/common": "6.8.1",
-    "@stacks/network": "6.8.1",
-    "@stacks/stacking": "6.9.0",
-    "@stacks/transactions": "6.9.0",
+    "@stacks/common": "6.10.0",
+    "@stacks/network": "6.11.3",
+    "@stacks/stacking": "6.11.3",
+    "@stacks/transactions": "6.11.3",
     "@types/express-list-endpoints": "4.0.1",
     "@types/lru-cache": "5.1.1",
     "@types/ws": "7.4.7",

package.json

@@ -37,6 +37,7 @@ import {
   MessageSignature,
   noneCV,
   OptionalCV,
+  principalCV,
   someCV,
   StacksTransaction,
   standardPrincipalCV,
@@ -310,6 +311,8 @@ export function createRosettaConstructionRouter(db: PgStore, chainId: ChainID):
       const request: RosettaConstructionMetadataRequest = req.body;
       const options: RosettaOptions = request.options;
 
+      let dummyTransaction: StacksTransaction;
+
       if (options?.sender_address && !isValidC32Address(options.sender_address)) {
         res.status(400).json(RosettaErrors[RosettaErrorsTypes.invalidSender]);
         return;
@@ -337,6 +340,20 @@ export function createRosettaConstructionRouter(db: PgStore, chainId: ChainID):
             res.status(400).json(RosettaErrors[RosettaErrorsTypes.invalidRecipient]);
             return;
           }
+
+          // dummy transaction to calculate fee
+          const dummyTokenTransferTx: UnsignedTokenTransferOptions = {
+            recipient: recipientAddress,
+            amount: 1n, // placeholder
+            publicKey: '000000000000000000000000000000000000000000000000000000000000000000', // placeholder
+            network: getStacksNetwork(),
+            nonce: 0, // placeholder
+            memo: '123456', // placeholder
+            anchorMode: AnchorMode.Any,
+          };
+          // Do not set fee so that the fee is calculated
+          dummyTransaction = await makeUnsignedSTXTokenTransfer(dummyTokenTransferTx);
+
           break;
         case RosettaOperationType.StackStx: {
           // Getting PoX info
@@ -353,6 +370,27 @@ export function createRosettaConstructionRouter(db: PgStore, chainId: ChainID):
           options.contract_address = contractAddress;
           options.contract_name = contractName;
           options.burn_block_height = burnBlockHeight;
+
+          // dummy transaction to calculate fee
+          const dummyStackingTx: UnsignedContractCallOptions = {
+            publicKey: '000000000000000000000000000000000000000000000000000000000000000000',
+            contractAddress: contractAddress,
+            contractName: contractName,
+            functionName: 'stack-stx',
+            functionArgs: [
+              uintCV(0),
+              poxAddressToTuple('bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4'), // placeholder
+              uintCV(0),
+              uintCV(1),
+            ],
+            validateWithAbi: false,
+            network: getStacksNetwork(),
+            nonce: 0,
+            anchorMode: AnchorMode.Any,
+          };
+          // Do not set fee so that the fee is calculated
+          dummyTransaction = await makeUnsignedContractCall(dummyStackingTx);
+
           break;
         }
         case RosettaOperationType.DelegateStx: {
@@ -361,6 +399,27 @@ export function createRosettaConstructionRouter(db: PgStore, chainId: ChainID):
           const [contractAddress, contractName] = contract.split('.');
           options.contract_address = contractAddress;
           options.contract_name = contractName;
+
+          // dummy transaction to calculate fee
+          const dummyDelegateStxTx: UnsignedContractCallOptions = {
+            publicKey: '000000000000000000000000000000000000000000000000000000000000000000',
+            contractAddress: 'ST000000000000000000002AMW42H',
+            contractName: 'pox',
+            functionName: 'delegate-stx',
+            functionArgs: [
+              uintCV(1), // placeholder
+              principalCV('SP3FGQ8Z7JY9BWYZ5WM53E0M9NK7WHJF0691NZ159.some-contract-name-v1-2-3-4'), // placeholder,
+              someCV(uintCV(1)), // placeholder
+              someCV(poxAddressToTuple('bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4')), // placeholder
+            ],
+            validateWithAbi: false,
+            network: getStacksNetwork(),
+            nonce: 0,
+            anchorMode: AnchorMode.Any,
+          };
+          // Do not set fee so that the fee is calculated
+          dummyTransaction = await makeUnsignedContractCall(dummyDelegateStxTx);
+
           break;
         }
         default:
@@ -392,8 +451,8 @@ export function createRosettaConstructionRouter(db: PgStore, chainId: ChainID):
       };
 
       // Getting fee info if not operation fee was given in /preprocess
-      const feeInfo = await new StacksCoreRpcClient().getEstimatedTransferFee();
-      if (feeInfo === undefined || feeInfo === '0') {
+      const feeValue = dummyTransaction.auth.spendingCondition.fee.toString();
+      if (feeValue === undefined || feeValue === '0') {
         res.status(400).json(RosettaErrors[RosettaErrorsTypes.invalidFee]);
         return;
       }
@@ -402,7 +461,7 @@ export function createRosettaConstructionRouter(db: PgStore, chainId: ChainID):
         res.status(400).json(RosettaErrorsTypes.missingTransactionSize);
         return;
       }
-      const feeValue = Math.round(Number(feeInfo) * Number(options.size) * 1.5).toString();
+
       const currency: RosettaCurrency = {
         symbol: RosettaConstants.symbol,
         decimals: RosettaConstants.decimals,

src/api/routes/rosetta/construction.ts

@@ -349,7 +349,7 @@ describe('Rosetta Construction', () => {
     expect(result.type).toBe('application/json');
     expect(JSON.parse(result.text)).toHaveProperty('metadata');
     expect(JSON.parse(result.text)).toHaveProperty('suggested_fee');
-    expect(JSON.parse(result.text).suggested_fee[0].value).toBe('270');
+    expect(parseInt(JSON.parse(result.text).suggested_fee[0].value)).toBeGreaterThan(100);
     expect(JSON.parse(result.text).metadata.memo).toBe('SAMPLE MEMO');
   });
 
@@ -1584,7 +1584,7 @@ describe('Rosetta Construction', () => {
     expect(JSON.parse(result.text).metadata).toHaveProperty('contract_address');
     expect(JSON.parse(result.text).metadata).toHaveProperty('contract_name');
     expect(JSON.parse(result.text).metadata).toHaveProperty('burn_block_height');
-    expect(JSON.parse(result.text).suggested_fee[0].value).toBe('390');
+    expect(parseInt(JSON.parse(result.text).suggested_fee[0].value)).toBeGreaterThan(100);
   });
 
   test('construction/metadata - delegate_stacking', async () => {
@@ -1638,7 +1638,9 @@ describe('Rosetta Construction', () => {
         account_sequence: nonce,
         recent_block_hash: '0x969e494d5aee0166016836f97bbeb3d9473bea8427e477e9de253f78d3212354',
       },
-      suggested_fee: [{ value: '390', currency: { symbol: 'STX', decimals: 6 } }],
+      suggested_fee: [
+        { value: expect.stringMatching(/^\d+$/), currency: { symbol: 'STX', decimals: 6 } },
+      ],
     };
 
     expect(result.body).toHaveProperty('metadata');
@@ -1808,7 +1810,7 @@ describe('Rosetta Construction', () => {
     expect(JSON.parse(resultMetadata.text).metadata).toHaveProperty('contract_address');
     expect(JSON.parse(resultMetadata.text).metadata).toHaveProperty('contract_name');
     expect(JSON.parse(resultMetadata.text).metadata).toHaveProperty('burn_block_height');
-    expect(JSON.parse(resultMetadata.text).suggested_fee[0].value).toBe('390');
+    expect(parseInt(JSON.parse(resultMetadata.text).suggested_fee[0].value)).toBeGreaterThan(100);
 
     //payloads
     const contract_address = resultMetadata.body.metadata.contract_address;
@@ -2255,7 +2257,9 @@ describe('Rosetta Construction', () => {
         account_sequence: nonce,
         recent_block_hash: '0x969e494d5aee0166016836f97bbeb3d9473bea8427e477e9de253f78d3212354',
       },
-      suggested_fee: [{ value: '380', currency: { symbol: 'STX', decimals: 6 } }],
+      suggested_fee: [
+        { value: expect.stringMatching(/^\d+$/), currency: { symbol: 'STX', decimals: 6 } },
+      ],
     };
     expect(resultMetadata.body).toHaveProperty('metadata');
     expect(resultMetadata.body.suggested_fee).toStrictEqual(metadataResponse.suggested_fee);