Fix Trakt device code auth and MKV external player support

- Fixed MKV files not opening in external player in Electron app
- Improved Trakt device code flow with automatic browser opening
- Enhanced error handling for Trakt configuration
- Reverted credential form UI, using .env configuration instead

Author: jack.cowey

client/package-lock.json

@@ -78,8 +78,12 @@ const Onboarding = () => {
       setTraktVerifyUrl(data.verification_url || "");
       setTraktDeviceCode(data.device_code || "");
       try { await navigator.clipboard.writeText(data.user_code || ""); } catch {}
-      if (data.verification_url && data.user_code) {
-        window.open(`${data.verification_url}?code=${encodeURIComponent(data.user_code)}`, "_blank");
+      // Always open browser with the verification URL and code
+      if (data.verification_url) {
+        const url = data.user_code 
+          ? `${data.verification_url}?code=${encodeURIComponent(data.user_code)}`
+          : data.verification_url;
+        window.open(url, "_blank");
       }
       // start polling
       const expires = Date.now() + (Number(data.expires_in || 600) * 1000);

client/src/pages/Onboarding.tsx

@@ -51,6 +51,46 @@ const Player = () => {
 
 
 
+  // Helper function to check if a URL is an MKV file
+  const isMkvFile = (url: string, filename?: string): boolean => {
+    if (filename && filename.toLowerCase().endsWith('.mkv')) return true
+    const urlLower = url.toLowerCase()
+    // Check URL path for .mkv extension
+    try {
+      const urlObj = new URL(url.startsWith('/') ? `${window.location.origin}${url}` : url)
+      if (urlObj.pathname.toLowerCase().endsWith('.mkv')) return true
+    } catch {}
+    // Fallback: check if URL contains .mkv
+    return urlLower.includes('.mkv')
+  }
+
+  // Helper function to check if we're in Electron
+  const isElectron = (): boolean => {
+    return typeof (window as any).electronAPI !== 'undefined'
+  }
+
+  // Helper function to open external player
+  const openExternalPlayer = async (url: string): Promise<boolean> => {
+    if (!isElectron()) {
+      console.log('Not in Electron, skipping external player')
+      return false
+    }
+    try {
+      const abs = url.startsWith('/') ? `${window.location.origin}${url}` : url
+      const result = await (window as any).electronAPI?.openExternalPlayer(abs)
+      if (result?.ok) {
+        console.log(`Opened in external player: ${result.player}`)
+        return true
+      } else {
+        console.error('Failed to open external player:', result?.error)
+        return false
+      }
+    } catch (e) {
+      console.error('Error opening external player:', e)
+      return false
+    }
+  }
+
   const pickSource = async (s: SourceItem) => {
     try {
       setResolvingId(s.id)
@@ -65,37 +105,45 @@ const Player = () => {
         if (r.status === 'ok' && r.directUrl) {
           setCompatibilityInfo(r)
 
-          // Handle MKV externally via system player (mpv/vlc)
-          if (r.format === 'mkv_native' && r.directUrl.includes('/api/stream/')) {
-            const abs = r.directUrl.startsWith('/') ? `${window.location.origin}${r.directUrl}` : r.directUrl
-            // Ask main process to open the external player
-            try { await (window as any).electronAPI?.openExternalPlayer(abs) } catch {}
-            // Show overlay briefly before navigating home
-            setExternalOpening(true)
-            setTimeout(() => { navigate('/') }, 1500)
-            return
-          } else {
-            setSelectedUrl(r.directUrl)
-            setFallbackUrl(null)
-
-            // Show compatibility warning for other limited formats
-            if (r.compatibility && r.compatibility.browserSupport === 'limited') {
-              setShowCompatibilityAlert(true)
+          // Handle MKV externally via system player (mpv/vlc) when in Electron
+          // Check if it's an MKV file by format, filename, or URL
+          const isMkv = r.format === 'mkv_native' || 
+                       isMkvFile(r.directUrl, r.filename) ||
+                       (r.compatibility?.format === 'mkv')
+          
+          if (isMkv && isElectron()) {
+            const opened = await openExternalPlayer(r.directUrl)
+            if (opened) {
+              // Show overlay briefly before navigating home
+              setExternalOpening(true)
+              setTimeout(() => { navigate('/') }, 1500)
+              return
             }
+            // If external player failed, fall through to try in-browser playback
+          }
+          
+          setSelectedUrl(r.directUrl)
+          setFallbackUrl(r.fallbackUrl || null)
+
+          // Show compatibility warning for other limited formats
+          if (r.compatibility && r.compatibility.browserSupport === 'limited') {
+            setShowCompatibilityAlert(true)
           }
         } else {
           // Handle non-streamable response
           setVideoError(r.message || r.reason || 'This source cannot be streamed')
           setCompatibilityInfo(r)
         }
       } else {
-        // Non-debrid direct link; if MKV, open externally
-        if (s.url.toLowerCase().includes('.mkv')) {
-          const abs = s.url.startsWith('/') ? `${window.location.origin}${s.url}` : s.url
-          try { await (window as any).electronAPI?.openExternalPlayer(abs) } catch {}
-          setExternalOpening(true)
-          setTimeout(() => { navigate('/') }, 1500)
-          return
+        // Non-debrid direct link; if MKV and in Electron, open externally
+        if (isMkvFile(s.url, s.name) && isElectron()) {
+          const opened = await openExternalPlayer(s.url)
+          if (opened) {
+            setExternalOpening(true)
+            setTimeout(() => { navigate('/') }, 1500)
+            return
+          }
+          // If external player failed, fall through to try in-browser playback
         }
         setSelectedUrl(s.url)
       }