Skip to content

Commit 89936d9

Browse files
SweetWuXiaoMeiliubao68
authored andcommitted
HHH-19365 - delete unused skip
1 parent f4cbf2b commit 89936d9

File tree

6 files changed

+2
-12
lines changed

6 files changed

+2
-12
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/bytecode/enhancement/merge/MergeUnsavedEntitiesTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,12 @@
99
import java.util.List;
1010
import java.util.Set;
1111

12-
import org.hibernate.dialect.GaussDBDialect;
1312
import org.hibernate.testing.bytecode.enhancement.extension.BytecodeEnhanced;
1413
import org.hibernate.testing.orm.junit.DomainModel;
1514
import org.hibernate.testing.orm.junit.Jira;
1615
import org.hibernate.testing.orm.junit.JiraKey;
1716
import org.hibernate.testing.orm.junit.SessionFactory;
1817
import org.hibernate.testing.orm.junit.SessionFactoryScope;
19-
import org.hibernate.testing.orm.junit.SkipForDialect;
2018
import org.junit.jupiter.api.Test;
2119

2220
import jakarta.persistence.Entity;
@@ -108,7 +106,6 @@ public void testMergeParentWithoutChildren(SessionFactoryScope scope) {
108106

109107
@Test
110108
@Jira("HHH-18177")
111-
@SkipForDialect(dialectClass = GaussDBDialect.class, reason = "opengauss don't support identity generation")
112109
public void testMergeTransientInstanceWithGeneratedId(SessionFactoryScope scope) {
113110
Book merged = scope.fromTransaction(
114111
session -> {

hibernate-core/src/test/java/org/hibernate/orm/test/hql/bitwise/BitwiseFunctionsTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
package org.hibernate.orm.test.hql.bitwise;
66

77
import org.hibernate.community.dialect.DerbyDialect;
8-
import org.hibernate.dialect.GaussDBDialect;
98
import org.hibernate.testing.orm.junit.DomainModel;
109
import org.hibernate.testing.orm.junit.SessionFactory;
1110
import org.hibernate.testing.orm.junit.SessionFactoryScope;
@@ -22,7 +21,6 @@
2221
public class BitwiseFunctionsTest {
2322

2423
@Test @SkipForDialect(dialectClass = DerbyDialect.class)
25-
@SkipForDialect( dialectClass = GaussDBDialect.class, reason = "not support")
2624
public void test(SessionFactoryScope scope) {
2725
IntEntity five = new IntEntity();
2826
five.setIntValue(5);

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/naturalid/MutableNaturalIdTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
package org.hibernate.orm.test.jpa.naturalid;
66

77
import org.hibernate.community.dialect.AltibaseDialect;
8-
import org.hibernate.dialect.GaussDBDialect;
98
import org.hibernate.dialect.HANADialect;
109
import org.hibernate.dialect.OracleDialect;
1110

@@ -27,8 +26,6 @@
2726
reason = "Hana do not support identity key generation")
2827
@SkipForDialect(dialectClass = AltibaseDialect.class,
2928
reason = "Altibase do not support identity key generation")
30-
@SkipForDialect(dialectClass = GaussDBDialect.class,
31-
reason = "Gauss do not support identity key generation")
3229
public class MutableNaturalIdTest extends AbstractJPATest {
3330
@Override
3431
protected Class<?>[] getAnnotatedClasses() {

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/query/QueryTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,6 @@ public void testQueryContainsQuotedSemicolonWithLimit() {
579579

580580
@Test
581581
@JiraKey("HHH-18033")
582-
@SkipForDialect(value = GaussDBDialect.class, comment = "Doesn't support semicolon as ending of statement")
583582
public void testNativeQueryContainsQuotedSemicolonWithLimit() {
584583
EntityManager em = getOrCreateEntityManager();
585584
em.getTransaction().begin();
@@ -606,7 +605,6 @@ public void testNativeQueryContainsQuotedSemicolonWithLimit() {
606605
@SkipForDialect(value = SybaseDialect.class, comment = "Doesn't support semicolon as ending of statement")
607606
@SkipForDialect(value = DerbyDialect.class, comment = "Doesn't support semicolon as ending of statement")
608607
@SkipForDialect(value = DB2Dialect.class, comment = "Doesn't support semicolon as ending of statement")
609-
@SkipForDialect(value = GaussDBDialect.class, comment = "Doesn't support semicolon as ending of statement")
610608
public void testNativeQueryContainsQuotedSemicolonAndEndsWithSemicolonWithLimit() {
611609
EntityManager em = getOrCreateEntityManager();
612610
em.getTransaction().begin();

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/schemagen/SchemaDatabaseFileGenerationFailureTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void destroy() {
7575
@JiraKey(value = "HHH-12192")
7676
@SkipForDialect(dialectClass = PostgreSQLDialect.class, matchSubTypes = true,
7777
reason = "on postgres we send 'set client_min_messages = WARNING'")
78-
@SkipForDialect( dialectClass = GaussDBDialect.class, reason = "type:resolved.on gauss we send 'set client_min_messages = WARNING'")
78+
@SkipForDialect( dialectClass = GaussDBDialect.class, reason = "on gauss we send 'set client_min_messages = WARNING'")
7979
public void testErrorMessageContainsTheFailingDDLCommand() {
8080
try {
8181
entityManagerFactoryBuilder.generateSchema();

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/schemagen/SchemaScriptFileGenerationFailureTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void destroy() {
6666
@JiraKey(value = "HHH-12192")
6767
@SkipForDialect(dialectClass = PostgreSQLDialect.class, matchSubTypes = true,
6868
reason = "on postgres we send 'set client_min_messages = WARNING'")
69-
@SkipForDialect( dialectClass = GaussDBDialect.class, reason = "type:resolved.on gauss we send 'set client_min_messages = WARNING'")
69+
@SkipForDialect( dialectClass = GaussDBDialect.class, reason = "on gauss we send 'set client_min_messages = WARNING'")
7070
public void testErrorMessageContainsTheFailingDDLCommand() {
7171
try {
7272
entityManagerFactoryBuilder.generateSchema();

0 commit comments

Comments
 (0)