code cleanups in LogicalConnectionManagedImpl

Author: gavinking

hibernate-core/src/main/java/org/hibernate/resource/jdbc/internal/LogicalConnectionManagedImpl.java

@@ -42,9 +42,9 @@ public class LogicalConnectionManagedImpl extends AbstractLogicalConnectionImple
 	private transient Connection physicalConnection;
 	private boolean closed;
 
-	public LogicalConnectionManagedImpl(JdbcSessionOwner sessionOwner, ResourceRegistry resourceRegistry) {
-		this.jdbcSessionOwner = sessionOwner;
-		this.resourceRegistry = resourceRegistry;
+	public LogicalConnectionManagedImpl(JdbcSessionOwner sessionOwner, ResourceRegistry registry) {
+		jdbcSessionOwner = sessionOwner;
+		resourceRegistry = registry;
 
 		connectionHandlingMode = determineConnectionHandlingMode( sessionOwner );
 		if ( connectionHandlingMode.getAcquisitionMode() == IMMEDIATELY ) {
@@ -131,10 +131,10 @@ public void afterStatement() {
 		super.afterStatement();
 		if ( connectionHandlingMode.getReleaseMode() == AFTER_STATEMENT ) {
 			if ( getResourceRegistry().hasRegisteredResources() ) {
-	CONNECTION_LOGGER.skipConnectionReleaseAfterStatementDueToResources( hashCode() );
+				CONNECTION_LOGGER.skipConnectionReleaseAfterStatementDueToResources( hashCode() );
 			}
 			else {
-	CONNECTION_LOGGER.initiatingConnectionReleaseAfterStatement( hashCode() );
+				CONNECTION_LOGGER.initiatingConnectionReleaseAfterStatement( hashCode() );
 				releaseConnectionIfNeeded();
 			}
 		}
@@ -144,7 +144,7 @@ public void afterStatement() {
 	public void beforeTransactionCompletion() {
 		super.beforeTransactionCompletion();
 		if ( connectionHandlingMode.getReleaseMode() == BEFORE_TRANSACTION_COMPLETION ) {
-CONNECTION_LOGGER.initiatingConnectionReleaseBeforeTransactionCompletion( hashCode() );
+			CONNECTION_LOGGER.initiatingConnectionReleaseBeforeTransactionCompletion( hashCode() );
 			releaseConnectionIfNeeded();
 		}
 	}
@@ -157,7 +157,7 @@ public void afterTransaction() {
 			// - AFTER_STATEMENT cases that were circumvented due to held resources
 			// - BEFORE_TRANSACTION_COMPLETION cases that were circumvented because a rollback occurred
 			//   (we don't get a beforeTransactionCompletion event on rollback).
-CONNECTION_LOGGER.initiatingConnectionReleaseAfterTransaction( hashCode() );
+			CONNECTION_LOGGER.initiatingConnectionReleaseAfterTransaction( hashCode() );
 			releaseConnectionIfNeeded();
 		}
 	}
@@ -167,7 +167,7 @@ public Connection manualDisconnect() {
 		if ( closed ) {
 			throw new ResourceClosedException( "Logical connection is closed" );
 		}
-		final Connection connection = physicalConnection;
+		final var connection = physicalConnection;
 		releaseConnectionIfNeeded();
 		return connection;
 	}
@@ -238,7 +238,7 @@ private void beforeRelease() {
 			jdbcSessionOwner.beforeReleaseConnection( physicalConnection );
 		}
 		catch (SQLException e) {
-CONNECTION_LOGGER.errorBeforeReleasingJdbcConnection( hashCode(), e );
+			CONNECTION_LOGGER.errorBeforeReleasingJdbcConnection( hashCode(), e );
 		}
 	}
 
@@ -256,14 +256,14 @@ public static LogicalConnectionManagedImpl deserialize(ObjectInputStream ois, Jd
 	public Connection close() {
 		if ( !closed ) {
 			getResourceRegistry().releaseResources();
-CONNECTION_LOGGER.closingLogicalConnection( hashCode() );
+			CONNECTION_LOGGER.closingLogicalConnection( hashCode() );
 			try {
 				releaseConnectionIfNeeded();
 			}
 			finally {
 				// no matter what
 				closed = true;
-	CONNECTION_LOGGER.logicalConnectionClosed( hashCode() );
+				CONNECTION_LOGGER.logicalConnectionClosed( hashCode() );
 			}
 		}
 		return null;