remove toVector() for HHVM 4.29+

Author: jjergus

src/RequestParametersCodegenBuilder.hack

@@ -83,8 +83,7 @@ final class RequestParametersCodegenBuilder<T as RequestParametersBase>
             $parameter['optional'] ? 'Optional' : '',
             $getter_spec['accessorSuffix'],
           ),
-          $getter_spec['args']->map($arg ==> $arg->render($param_spec))
-            ->toVector(),
+          $getter_spec['args']->map($arg ==> $arg->render($param_spec)),
           /* semicolon at end = */ false,
         )
         ->add(',');

src/UriBuilderCodegenBuilder.hack

@@ -54,7 +54,7 @@ extends RequestParametersCodegenBuilderBase<UriBuilderCodegenBase<T>> {
               $param,
               \sprintf('$parameters[\'%s\']', $param->getName()),
             ),
-          )->toVector(),
+          ),
           /* semicolon at end = */ false,
         );
     }

tests/examples/GetRequestExampleController.hack

@@ -37,9 +37,10 @@ implements
 
   final public static function __getParametersSpec(
   ): ImmVector<shape('spec' => RequestParameter, 'optional' => bool)> {
-    $params = static::getUriPattern()->getParameters()->map(
-      $param ==> shape('spec' => $param, 'optional' => false),
-    )->toVector();
+    $params = new Vector(
+      static::getUriPattern()->getParameters()
+        ->map($param ==> shape('spec' => $param, 'optional' => false)),
+    );
     $params[] = shape(
       'spec' => new StringRequestParameter(
         StringRequestParameterSlashes::WITHOUT_SLASHES,