Add linter

Author: fredemmott

.travis.sh

@@ -6,7 +6,7 @@ composer install
 
 hh_client
 hhvm vendor/bin/phpunit
-#hhvm vendor/bin/hhast-lint
+hhvm vendor/bin/hhast-lint
 
 # Make sure we pass when a release is required
 EXPORT_DIR=$(mktemp -d)

composer.json

@@ -12,7 +12,8 @@
     },
     "require-dev": {
         "91carriage/phpunit-hhi": "^5.5",
-        "phpunit/phpunit": "^5.5"
+        "phpunit/phpunit": "^5.5",
+        "hhvm/hhast": "^1.0"
     },
     "extra": {
         "branch-alias": {

composer.lock

@@ -0,0 +1,13 @@
+{
+  "roots": [ "src/", "tests/" ],
+  "builtinLinters": "all",
+  "disabledLinters": [
+    "Facebook\\HHAST\\Linters\\UseStatementWithAsLinter"
+  ],
+  "overrides": [
+    {
+      "patterns": [ "tests/examples/codegen/*" ],
+      "disableAllAutoFixes": true
+    }
+  ]
+}

hhast-lint.json

@@ -38,6 +38,7 @@ private static function getTypeName(
     return self::getType($param).'::class';
   }
 
+  <<__Override>>
   final public static function getGetterSpec(
     RequestParameter $param,
   ): self::TSpec {
@@ -51,6 +52,7 @@ final public static function getGetterSpec(
     );
   }
 
+  <<__Override>>
   public static function getSetterSpec(
     UriParameter $param,
   ): self::TSpec {

src/uriparameters/spec/EnumParameterCodegenSpec.php

@@ -14,6 +14,7 @@
 use \Facebook\HackRouter\UriParameterCodegenArgument as Arg;
 
 final class IntParameterCodegenSpec extends SimpleParameterCodegenSpec {
+  <<__Override>>
   protected static function getSimpleSpec(): self::TSimpleSpec {
     return shape(
       'type' => 'int',

src/uriparameters/spec/IntParameterCodegenSpec.php

@@ -20,6 +20,7 @@ abstract class SimpleParameterCodegenSpec extends UriParameterCodegenSpec {
   );
   abstract protected static function getSimpleSpec(): self::TSimpleSpec;
 
+  <<__Override>>
   final public static function getGetterSpec(
     RequestParameter $_,
   ): self::TSpec {
@@ -33,6 +34,7 @@ final public static function getGetterSpec(
     );
   }
 
+  <<__Override>>
   public static function getSetterSpec(
     UriParameter $_,
   ): self::TSpec {

src/uriparameters/spec/SimpleParameterCodegenSpec.php

@@ -14,6 +14,7 @@
 use \Facebook\HackRouter\UriParameterCodegenArgument as Arg;
 
 final class StringParameterCodegenSpec extends SimpleParameterCodegenSpec {
+  <<__Override>>
   protected static function getSimpleSpec(): self::TSimpleSpec {
     return shape(
       'type' => 'string',

src/uriparameters/spec/StringParameterCodegenSpec.php

@@ -31,7 +31,7 @@ private function getBuilder(
       new ClassFacts($parser),
     ));
   }
-  
+
   public function testCreatesRoutes(): void {
     $scanned = FileParser::FromFile(
       __DIR__.'/examples/GetRequestExampleController.php',

tests/UriMapBuilderTest.php

@@ -57,6 +57,7 @@ final class GetRequestExampleController extends WebController {
   use Generated\GetRequestExampleControllerUriBuilderTrait;
   use Generated\GetRequestExampleControllerParametersTrait;
 
+  <<__Override>>
   public static function getUriPattern(): UriPattern {
     return (new UriPattern())
       ->literal('/')