instanceof -> is, require 4.13

Author: fredemmott

.travis.yml

@@ -2,7 +2,7 @@ sudo: required
 language: generic
 services: docker
 env:
-- HHVM_VERSION=4.6-latest
+- HHVM_VERSION=4.13-latest
 - HHVM_VERSION=latest
 - HHVM_VERSION=nightly
 install:

composer.json

@@ -4,8 +4,8 @@
     "keywords": ["hack", "router", "routing", "hhvm"],
     "homepage": "https://github.com/hhvm/hack-router-codegen",
     "require": {
-        "hhvm": "^4.6",
-        "facebook/hack-router": "^0.18",
+        "hhvm": "^4.13",
+        "facebook/hack-router": "^0.19",
         "facebook/hack-http-request-response-interfaces": "^0.2",
         "facebook/hack-codegen": "^4.1.0",
         "facebook/definition-finder": "^2.7",

src/privateimpl/ClassFacts.hack

@@ -36,7 +36,7 @@ final class ClassFacts {
   ): ImmMap<classname<T>, ScannedClass> {
     $mappable = Map { };
     foreach ($this->classes as $class) {
-      if (!$class instanceof ScannedClass) {
+      if (!$class is ScannedClass) {
         continue;
       }
       $name = $this->asClassname($wanted, $class->getName());

src/privateimpl/ControllerFacts.hack

@@ -42,7 +42,7 @@ final class ControllerFacts<T as IncludeInUriMap> {
   private function isUriMappable(
     ScannedClassish $class
   ): bool {
-    if (!$class instanceof ScannedClass) {
+    if (!$class is ScannedClass) {
       return false;
     }
     if ($class->isAbstract()) {

src/uriparameters/spec/EnumParameterCodegenSpec.hack

@@ -16,7 +16,7 @@ final class EnumParameterCodegenSpec extends UriParameterCodegenSpec {
     RequestParameter $param,
   ): EnumRequestParameter<T> {
     invariant(
-      $param instanceof EnumRequestParameter,
+      $param is EnumRequestParameter<_>,
       'Expected %s to be an enum parameter, got %s',
       $param->getName(),
       \get_class($param),

tests/RouterCodegenBuilderTest.hack

@@ -65,7 +65,7 @@ final class RouterCodegenBuilderTest extends BaseCodegenTestCase {
       self::CODEGEN_NS,
       'MySiteRouter',
     );
-    assert($class instanceof \Facebook\HackCodegen\CodegenFile);
+    assert($class is \Facebook\HackCodegen\CodegenFile);
     return $class->render();
   }