Update for gpg key handler for RHEL 8 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(as far as i can tell the failed checks have nothing to do with the changes) |
|
I'm actually going to hold off on the other patch for the moment until this one gets accepted. So I don't complicate things. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy! RHEL8 changes the output of gpg a bit and it makes rpm_gpg_key fail to properly detect that the associated key is installed. This is basically the same fix as:
voxpupuli/puppet-epel#84
from the epel module.
That said, it looks like the RHEL8 rpms have been signed with one of the newer keys. I'm also working on a separate PR to provide a solution for that. That said, the fix for that is going to be a little more drastic.