Feature: Add labels/metadata to created volumes on hetzner cloud

[micw]

Currently, volumes are created with the pv name, so the only information about a volume is the name (pvc-{$UUID}), the size, and the creation date. To manage a larger number of volumes, it would be very good if additional labels could be added to the hcloud volume. E.g. the claim name, the namespace and annotations of the original PVC could be added as labels to the volume created in hetzner cloud.

[captnCC]

Additionally support for custom preset labels would be a huge helper. This could help be greater helper to identify resources in a automated environment via the hcloud cli!

[github-actions]

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

[micw]

Not stale!

[schmidp]

I am also very interested in this feature.

[aki-ks]

Likewise interested. I'd like to attach the name of my kubernetes cluster to volumes to distinguish which one they belong to.

[kayiplar]

Also interested!

[github-actions]

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

[micw]

Not stale!

[jr-dimedis]

I'd love this feature, too.

[nicolai0]

+1 for this feature

[platdesign]

+1

[apricote]

Some thoughts:

This is a generic csi-driver that must be compatible with other tools besides Kubernetes, accessing the Kubernetes API to get more information is out of the question.

The CreateVolume gRPC call does not include "Labels" or similar that we could directly pass through. What it makes available are map<string, string> parameters. In Kubernetes these are the options you configure in StorageClass.parameters.

Kubernetes uses a tool called external-provisioner to call CreateVolume when new PVs are created. It has a flag --extra-create-metadata, if this is active we will receive parameters for the PVC Name & Namespace and PV Name. While these are Kubernetes-specific parameters, I think we can still convert them into Volume Labels.

We could additional define a prefix like labels.csi.hetzner.cloud for parameters, such that a parameter labels.csi.hetzner.cloud/foo: bar would result in the label foo=bar on the Hetzner Cloud Volume. This could be used by any Container Orchestrator. In Kubernetes this would enable setting different labels per StorageClass, so you could for example add the name of the Cluster in there.

[Masegi]

+1, we need this please.

[niklasweimann]

I'd love this feature, too.

[TimoGoetze]

• one more :-)

[rwojsznis]

I'm glad to find that somebody thought about it 2 years before I ran into same problem; I recently pruned a volume by accident as I was sure it was dangling one from some experiment just to find out it actually belonged to a still used (kinda forgotten, but very much needed) cronjob - which obviously started to fail after I deleted it's volume outside of k8s :badpokerface:

having labels where you could specify cluster name and volume name among other human-readable stuff would be lovely <3

[mrsimonemms]

I've had a look at the source code and this actually seems a fairly simple thing to do. Happy to raise a PR if it's likely to be accepted by the Hetzner folk.

There are two, mutually-exclusive, places where this could be done - at volume creation or volume attach. My thought is to do it when the volume is attached, mainly so that the labels are added to volumes that have been created with a previous version of the CSI without this support. Thoughts?

Also, what labels would be applied? My thinking is to add any labels that are present on the PersistentVolume resource and the name and namespace of the PersistentVolumeClaim by default.

[Masegi]

I think that sounds completly right and we need this :D

[mrsimonemms]

@Masegi I finish for the year on Tuesday - I'll have a bash next week

[mrsimonemms]

I've had a bit of a look at this today and it's going to be a bit more awkward than first thought. The Hetzner side is fairly easy, but the container-storage-interface doesn't receive anything about the PVC's name or namespace.

I'll have a look at how other CSI drivers do it and take my lead from them.