-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtio: consider avoiding dynamic dispatch with enum_dispatch
#989
Comments
I think we can close this issue since using a trait and trait objects worked out for |
enum_dispatch
enum_dispatch
This issue is about potential performance improvements, not about whether we need it to work at all. I have reworked the description. This issue might be interesting for @CarlWachter, who will be working on benchmarking. CC: @jounathaen |
Before
02860f2
, there was an enum for abstracting over split and packed virtqueues:Currently, we are using a trait via
Rc<dyn Virtq>
instead ofRc<Virtq>
.We need to consider automating the previous enum-based static dispatch via
enum_dispatch
for performance.This would be a nice fit because restricting the set of implementors is no problem for us.
This might not have a too much of an impact, depending on how hot these dynamic dispatches are right now.
The text was updated successfully, but these errors were encountered: