Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in _compute_backward_tracks #44

Open
RafailFridman opened this issue Nov 3, 2024 · 1 comment
Open

Bug in _compute_backward_tracks #44

RafailFridman opened this issue Nov 3, 2024 · 1 comment

Comments

@RafailFridman
Copy link

Hi!
Thanks for your work.
I found a bug in the _compute_backward_tracks function:

There, in line 275, you write:

inv_tracks, __, inv_visibilities = self.model(
            rgbds=inv_video, queries=queries, iters=6
        )

which uses original (not flipped) queries.

I think that instead, it should be

inv_tracks, __, inv_visibilities = self.model(
            rgbds=inv_video, queries=inv_queries, iters=6
        )

Notice that I changed queries to inv_queries.

This bug is possibly related to #41 .
Also, this model call should probably accept the wind_S to make it consistent with the forward tracking model call.

I did not create a pull request, but I can make one if you accept them from other people.

@RafailFridman
Copy link
Author

A related question:
You add a support points grid at frame 0.
But when you want to track backward, you flip all the queries, including the support grid queries, which now "start" at the last frame of the video, and are not supporting the tracking process.
Am I missing something here?

Shouldn't the support grid be recreated again to start from frame zero also in the flipped video?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant