Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force push breaks github integration #356

Open
lukemarsden opened this issue Jul 17, 2024 · 3 comments
Open

force push breaks github integration #356

lukemarsden opened this issue Jul 17, 2024 · 3 comments

Comments

@lukemarsden
Copy link
Collaborator

seemingly if you force push a repo (e.g. to a previous commit), github integration doesn't update the commit in the app

@lukemarsden
Copy link
Collaborator Author

api-1  | 2024-07-17T11:02:29Z ERR pkg/server/github_handlers.go:131 > error updating github app: failed to pull repo: non-fast-forward update

@lukemarsden
Copy link
Collaborator Author

lukemarsden commented Jul 17, 2024

we shouldn't be pulling, we should be fetching and then checking out the specific commit included in the github webhook (and then, we also need to be dealing with different branches)

@lukemarsden
Copy link
Collaborator Author

per pkg/github/utils.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant