Skip to content

Commit 8fa47d8

Browse files
committed
Hack more exceptions to ignore
There are concurrent shutdown issues with WEBrick that have never been fixed (ruby/webrick#102 which may explain why we get these sporadic failures in several of the net/http tests: ``` 1) Error: TestNetHTTP_v1_2#test_s_start: Errno::EPIPE: Broken pipe - No message available org/jruby/RubyIO.java:1391:in `write_nonblock' /home/runner/work/jruby/jruby/test/tool/lib/webrick/server.rb:227:in `block in stop' /home/runner/work/jruby/jruby/test/tool/lib/webrick/server.rb:352:in `alarm_shutdown_pipe' /home/runner/work/jruby/jruby/test/tool/lib/webrick/server.rb:227:in `stop' /home/runner/work/jruby/jruby/test/tool/lib/webrick/server.rb:235:in `shutdown' /home/runner/work/jruby/jruby/test/mri/net/http/utils.rb:37:in `teardown' ``` I have commented on the issue and this commit adds more exceptions to ignore in an attempt to prevent unsafe shutdown from causing any tests to fail.
1 parent ddb926d commit 8fa47d8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: test/tool/lib/webrick/server.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ def alarm_shutdown_pipe
350350
if !pipe.closed?
351351
begin
352352
yield pipe
353-
rescue IOError # closed by another thread.
353+
rescue IOError, Errno::EBADF, Errno::EPIPE # closed by another thread.
354354
end
355355
end
356356
end

0 commit comments

Comments
 (0)