Skip to content

Commit c043475

Browse files
ci fixes
Signed-off-by: denis-tingaikin <[email protected]>
1 parent 7e87752 commit c043475

File tree

10 files changed

+6
-18
lines changed

10 files changed

+6
-18
lines changed

.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ jobs:
123123
restore-keys: ${{ runner.os }}-build-${{ env.cache-name }}-${{ github.sha }}
124124

125125
- name: Checking svelte sources...
126-
run: node common/scripts/install-run-rush.js svelte-check
126+
run: node common/scripts/install-run-rush.js svelte-check -v
127127
formatting:
128128
needs: build
129129
runs-on: ubuntu-latest

packages/ui/src/components/HlsVideo.svelte

-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@
144144
})
145145
}
146146
}
147-
148147
</script>
149148

150149
<video bind:this={video} width="100%" height="100%" class="plyr" preload={preload ? 'auto' : 'none'} controls>

packages/ui/src/components/Popup.svelte

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
close={popup.close}
4646
{contentPanel}
4747
overlay={popup.options.overlay}
48-
ignoreEvents={popup.options.ignoreEvents}
4948
{popup}
5049
/>
5150
{/each}

packages/ui/src/components/PopupInstance.svelte

-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
export let onClose: ((result: any) => void) | undefined
2626
export let onUpdate: ((result: any) => void) | undefined
2727
export let overlay: boolean
28-
export let ignoreEvents: boolean
2928
export let zIndex: number
3029
export let top: boolean
3130
export let close: () => void
@@ -36,7 +35,6 @@
3635
// since they could be used, and any show will update them
3736
// So special update callback should be used.
3837
let initialProps: Record<string, any> = props
39-
const pointerEvents = ignoreEvents ? 'none' : 'auto'
4038
4139
$: popup.update = (props) => {
4240
initialProps = Object.assign(initialProps, props)

packages/ui/src/popups.ts

-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ export function showPopup (
9191
category: string
9292
overlay: boolean
9393
fixed?: boolean
94-
ignoreEvents?: boolean
9594
refId?: string
9695
} = {
9796
category: 'popup',

plugins/recorder-resources/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@hcengineering/recorder-resources",
33
"version": "0.6.0",
44
"main": "src/index.ts",
5-
"author": "Hardcore Engineering Inc.",
5+
"author": "Anticrm Platform Contributors",
66
"license": "EPL-2.0",
77
"scripts": {
88
"build": "compile ui",

plugins/recorder-resources/src/components/Countdown.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<div class="countdown">
4545
{count}
4646
<span class="countdown-info-text">
47-
<Label label = {plugin.string.ClickToSkip}/>
47+
<Label label={plugin.string.ClickToSkip} />
4848
</span>
4949
</div>
5050
</div>

plugins/uploader-resources/src/components/FileUploadExt.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
{#if $uploads.size > 0}
2121
<div class="flex-row-center flex-gap-2">
22-
{#each $uploads as [v]}
22+
{#each $uploads as [_, v]}
2323
<FileUploadStatusBar upload={v} />
2424
{/each}
2525
</div>

tests/sanity/tests/drive/drive.spec.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { test } from '@playwright/test'
2-
import { PlatformSetting, PlatformURI } from '../utils'
2+
import { PlatformSetting, PlatformURI, uploadFile } from '../utils'
33
import { Drive } from '../model/drive/types'
44
import { faker } from '@faker-js/faker'
55
import { DriveLeftMenu } from '../model/drive/drive-left-menu'
@@ -69,9 +69,8 @@ test.describe('Drive tests', () => {
6969

7070
test('Upload/rename/delete file, check file was uploaded, renamed and deleted', async () => {
7171
await drivesPage.clickOnDrive(drive)
72-
await leftMenu.clickUploadFiles()
7372
const fileName = 'cat.jpeg'
74-
await filesPage.uploadFile(fileName)
73+
await uploadFile(leftMenu.page, fileName, 'Upload files')
7574
await filesPage.checkFileExists(fileName)
7675
const newFileName = 'dog.jpeg'
7776
await filesPage.renameFile(fileName, newFileName)

tests/sanity/tests/model/drive/drive-files-page.ts

-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { expect, type Locator, type Page } from '@playwright/test'
22
import { ButtonFilesContextMenu } from './types'
3-
import { uploadFile } from '../../utils'
43
import { CommonPage } from '../common-page'
54

65
export class DriveFilesPage extends CommonPage {
@@ -17,11 +16,6 @@ export class DriveFilesPage extends CommonPage {
1716
readonly buttonContextMenu = (buttonText: ButtonFilesContextMenu): Locator =>
1817
this.page.locator('div.antiPopup').getByRole('button', { name: buttonText })
1918

20-
async uploadFile (fileName: string): Promise<void> {
21-
await uploadFile(this.page, fileName, 'My device')
22-
await this.buttonConfirmUpload().click()
23-
}
24-
2519
async checkFileExists (fileName: string): Promise<void> {
2620
await expect(this.linkFile(fileName)).toBeVisible()
2721
}

0 commit comments

Comments
 (0)