Skip to content

Commit 40a1e9a

Browse files
Add data-id to Header component, fix locators
Signed-off-by: Rostislav Nazmeev <[email protected]>
1 parent 4e5c045 commit 40a1e9a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

plugins/chunter-resources/src/components/Header.svelte

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@
141141
iconProps={{ size: 'small' }}
142142
kind={'icon'}
143143
showTooltip={{ label: workbench.string.OpenInSidebar }}
144+
dataId='open-in-sidebar'
144145
on:click={() => {
145146
if (object !== undefined) {
146147
void openChannelInSidebar(object._id, object._class, object, undefined, true)
@@ -166,6 +167,7 @@
166167
icon={IconSettings}
167168
iconProps={{ size: 'medium' }}
168169
kind={'icon'}
170+
dataId='aside-toggle'
169171
showTooltip={{ label: chunter.string.Settings }}
170172
selected={isAsideShown}
171173
on:click={() => dispatch('aside-toggled')}

tests/sanity/tests/model/channel-page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class ChannelPage extends CommonPage {
6262
readonly copyLinkButton = (): Locator => this.page.getByRole('button', { name: 'Copy link' })
6363
readonly deleteMessageButton = (): Locator => this.page.getByRole('button', { name: 'Delete' })
6464
readonly updateButton = (): Locator => this.page.getByRole('button', { name: 'Update' })
65-
readonly openChannelDetails = (): Locator => this.page.locator('.hulyHeader-buttonsGroup > .antiButton')
65+
readonly openChannelDetails = (): Locator => this.page.getByTestId('aside-toggle')
6666
readonly changeChannelNameConfirm = (): Locator => this.page.locator('.selectPopup button')
6767
readonly privateOrPublicChangeButton = (change: string, autoJoin: boolean): Locator =>
6868
this.page

0 commit comments

Comments
 (0)