Current repo state does not resolve excessive junimo spawning issue

[samipfjo]

Hi! Thanks for your awesome mod!

I built the mod using your latest patches, and unfortunately they do not appear to have fixed the junimo spawning problem that was described in a bunch of recently resolved Issues. I have spent some time playing around with different configurations and have discovered the following data points:

• Provided junimos are able to spawn in the current environment, the only variables at play are MaxJunimos and MaxRadius
• MaxJunimos is never respected (though it may be respected at 1, I don't recall)
• MaxRadius is the most significant factor

I suspect one or more junimos are being spawned for every crop within the radius, leading to MaxJunimos = 3, MaxRadius = 3 spawning 150+ junimos. Junimos also appear to spawn on top of each other, resulting in a flickering rainbow junimo that would be super cool if it didn't turn Stardew into a slideshow :P

Hopefully that helps in tracking down the issue at play.

[hawkfalcon]

Darn, thanks for trying it. I haven't had much time to put into fixing these issues. That's wild. When I get a chance I'll try again to fix it. I also accept PR's (':))

[Rafia-Bee]

Hi, I tried fiddling around with the code and it seems to me there was a feedback loop caused by BonusMaxJunimos calculation.
junimos visit greenhouse -> BonusMaxJunimos increases -> MaxJunimosUnlocked increases -> more junimos spawn -> more visit greenhouse etc.
I undid the changes in commit f72309c and it seemed to fix the problem for me. I set maxRadius to 40 and maxJunimos to 10, all progression skills unlocked and junimos are harvesting from summit farm and my normal farm properly.

However I should note, before I undid that commit, the infinite junimo spawn was occurring on my Summit farm (from Ridgeside village mod), which has no greenhouses. At that point, I only had 1 junimo hut and that was on the Summit farm. So the greenhouse calculation shouldn't have even been occurring anyways.

So it is entirely possible that there is another problem somewhere else in the code. So far I've played about 2 ingame seasons with 1 Junimo Hut on Summit farm and 1 Junimo Hut on my main farm. Other than occasional stutters, I haven't had any issues.

EDIT: My junimos only visited the greenhouse once throughout my playthrough after I reverted the mentioned commit, so I guess it did break some functionality of junimos working in greenhouse. However, the duplication problem went away at least.

[bronxinator]

hello, I'm not sure if this is where to say this. but I was having the same issue with infinite junimos spawning on the summit farm from the ridgeside village mod and came looking for help. Rafia-bee says there is no greenhouses on the summit farm but in the mod you can upgrade the entire farm area to act like a greenhouse. I was thinking the feedback loop they described is exacerbated in that area perhaps by the way ridgeside handles giving that area greenhouse properties. I have no programming experience and do not know how to use GitHub but I thought this insight might be useful.

[Bethinski]

As per Rafia-Bee and bronxinator I can confirm that I only got infinitely spawning Junimos o my summit farm once I'd received the "climate control" upgrade which makes the farm act as a greenhouse - you can plant from any season at any time