Skip to content

Add platforms input to build workflow#276

Merged
kron-spar merged 1 commit intomainfrom
ETT-696
Dec 8, 2025
Merged

Add platforms input to build workflow#276
kron-spar merged 1 commit intomainfrom
ETT-696

Conversation

@kron-spar
Copy link
Copy Markdown
Contributor

Steps taken to test the fix

  • Deleted the previous packages located in actions_playground
  • Confirmed that the platform variable was passed in the job
  • Ensured that the right platform was being passed to the commands that build the image.
  • Pulled the image via docker pull ghcr.io/hathitrust/actions_playground:unstable and found "Architecture": "amd64" after inspecting the image.

Since these changes worked in the playground repository, they should work here too.

@kron-spar kron-spar requested a review from aelkiss December 8, 2025 20:37
Copy link
Copy Markdown
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Looking across our other repos, is this generally an issue (needing to pass through platforms), or was it only missing for otis?

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 98.225%. remained the same
when pulling 7189d0c on ETT-696
into 23eeb55 on main.

@kron-spar
Copy link
Copy Markdown
Contributor Author

Makes sense to me. Looking across our other repos, is this generally an issue (needing to pass through platforms), or was it only missing for otis?

It's a general issue and I will be doing this across all repos that use the build action.

@kron-spar kron-spar merged commit 4b159a8 into main Dec 8, 2025
2 checks passed
@kron-spar kron-spar deleted the ETT-696 branch December 9, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants