Skip to content

Commit ea8e16a

Browse files
committed
ETT-44: Use env vars for database config
Also: ETT-36: remove version.rb
1 parent 76040e9 commit ea8e16a

6 files changed

Lines changed: 19 additions & 22 deletions

File tree

config/config.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,3 @@ dest_parent_dir:
1919
:pd_open: '/tmp/datasets/ht_text_pd_open_access'
2020
:pd_world: '/tmp/datasets/ht_text_pd_world'
2121
:pd_world_open: '/tmp/datasets/ht_text_pd_world_open_access'
22-
23-
db:
24-
adapter: mysql2
25-
database: ht
26-
host: mariadb-dev
27-
user: datasets
28-
password: datasets

config/hathitrust_config.rb

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,14 @@ def volume_repo
4747
end
4848

4949
def db_connection
50-
# Example with logging enabled
51-
# @db_connection ||= Sequel.connect(db.merge({loggers: [Logger.new($stdout)]}))
52-
@db_connection ||= Sequel.connect(db)
50+
@db_connection ||= Sequel.connect(
51+
adapter: "mysql2",
52+
user: ENV["MARIADB_HT_RO_USERNAME"],
53+
password: ENV["MARIADB_HT_RO_PASSWORD"],
54+
host: ENV["MARIADB_HT_RO_HOST"],
55+
database: ENV["MARIADB_HT_RO_DATABASE"],
56+
encoding: "utf8mb4"
57+
)
5358
end
5459

5560
def filter

docker-compose.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ x-common-service: &common-service
1919
environment:
2020
REDIS_URL: redis://redis/
2121
PREVIEW_EMAIL: true
22+
MARIADB_HT_RO_HOST: mariadb-dev
23+
MARIADB_HT_RO_USERNAME: datasets
24+
MARIADB_HT_RO_PASSWORD: datasets
25+
MARIADB_HT_RO_DATABASE: ht
2226

2327
services:
2428

@@ -29,6 +33,13 @@ services:
2933
depends_on:
3034
redis: *healthy
3135
mariadb-test: *healthy
36+
environment:
37+
REDIS_URL: redis://redis/
38+
PREVIEW_EMAIL: true
39+
MARIADB_HT_RO_HOST: mariadb-test
40+
MARIADB_HT_RO_USERNAME: datasets
41+
MARIADB_HT_RO_PASSWORD: datasets
42+
MARIADB_HT_RO_DATABASE: ht
3243

3344
processor:
3445
<<: *common-service

lib/datasets.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
require "datasets/version"
2-
31
require "datasets/configuration"
42
require "datasets/job"
53
require "datasets/jobs/delete_job"

lib/datasets/version.rb

Lines changed: 0 additions & 3 deletions
This file was deleted.

spec/support/config/integration.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,3 @@ dest_parent_dir:
1818
:pd_open: '/tmp/integration/datasets/ht_text_pd_open_access'
1919
:pd_world: '/tmp/integration/datasets/ht_text_pd_world'
2020
:pd_world_open: '/tmp/integration/datasets/ht_text_pd_world_open_access'
21-
22-
db:
23-
adapter: mysql2
24-
database: ht
25-
host: mariadb-test
26-
user: datasets
27-
password: datasets

0 commit comments

Comments
 (0)