Error 400 in RPC Manifest for pwgen

[darkyat]

Unluckily it seems something broke in the commit 5040444 by using pwgen.

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: wrong number of arguments (1 for 0) at /etc/puppet/modules/kickstack/manifests/rpc.pp:8 on node puppetclient

It seems like he is interpreting "pwgen()" as being filled with an argument even if it's empty?

I've spent now nearly 2 hours trying to fix this problem.

[fghaas]

@darkyat, thanks for reporting this. I'll look into it.

[darkyat]

Thanks for taking care of this!

This happens to me everywhere pwgen() is used.
I'm now locally removing the pwgen lines and set them "oldstyle" as fixed variables inside the params for the time being even if this means an exposure of the password in plaintext. Since I'm pretty sure you will have a clean solution I will not open a pull request.

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: wrong number of arguments (1 for 0) at /etc/puppet/modules/kickstack/manifests/db.pp:16 on node puppetclient

Here some additional informations:

OS: Ubuntu 13.10 (Saucy Salamander)
Package: pwgen (Version: 2.06-1ubuntu4)
Puppet Module: rgevaert-pwgen (v0.0.1)

[darkyat]

In my opinion pwgen() should be simply run as pwgen without brackets since no arguments are specified. Even if this looks odd for every other programming language it seems to be perfectly normal for ruby.

My ruby knowledge is very low so you are invited to tell me something completely different.

[dlsmartins]

In my case this is causing an even weirder and cryptic error: Error 400 on SERVER: Must provide non empty value.
Replacing pwgen() with just pwgen, as suggested by darkyat, seems to fix the problem.