Re CLC issue 292 Avoid using partial init and last

Author: mpilgrem

lib/Data/Format.hs

@@ -1,3 +1,4 @@
+{-# LANGUAGE CPP  #-}
 {-# LANGUAGE Safe #-}
 
 module Data.Format (
@@ -26,6 +27,7 @@ module Data.Format (
 
 import Control.Monad.Fail
 import Data.Char
+import qualified Data.List as L
 import Data.Void
 import Text.ParserCombinators.ReadP
 import Prelude hiding (fail)
@@ -227,11 +229,17 @@ zeroPad Nothing s = s
 zeroPad (Just i) s = replicate (i - length s) '0' ++ s
 
 trimTrailing :: String -> String
-trimTrailing "" = ""
 trimTrailing "." = ""
-trimTrailing s
-    | last s == '0' = trimTrailing $ init s
-trimTrailing s = s
+trimTrailing s = case L.unsnoc s of
+    Nothing -> ""
+    Just (initial, '0') -> trimTrailing initial
+    _ -> s
+
+#if !MIN_VERSION_base(4,19,0)
+unsnoc :: [a] -> Maybe ([a], a)
+unsnoc = foldr (\x -> Just . maybe ([], x) (\(~(a, b)) -> (x : a, b))) Nothing
+{-# INLINABLE unsnoc #-}
+#endif
 
 showNumber :: Show t => SignOption -> Maybe Int -> t -> Maybe String
 showNumber signOpt mdigitcount t =

test/unix/Test/Format/Format.hs

@@ -1,3 +1,4 @@
+{-# LANGUAGE CPP #-}
 {-# OPTIONS -fno-warn-orphans #-}
 
 module Test.Format.Format (
@@ -6,6 +7,7 @@ module Test.Format.Format (
 
 import Data.Char
 import Data.Fixed as F
+import qualified Data.List as L
 import Data.Time
 import Data.Time.Clock.POSIX
 import Foreign
@@ -151,16 +153,25 @@ unixWorkarounds fmt s
 unixWorkarounds _ s = s
 
 compareFormat :: (String -> String) -> String -> TimeZone -> UTCTime -> Result
-compareFormat _modUnix fmt zone _time
-    | last fmt == 'Z' && timeZoneName zone == "" = rejected
-compareFormat modUnix fmt zone time =
-    let
-        ctime = utcToZonedTime zone time
-        haskellText = formatTime locale fmt ctime
-        unixText = unixFormatTime fmt zone time
-        expectedText = unixWorkarounds fmt (modUnix unixText)
-    in
-        assertEqualQC (show time ++ " with " ++ show zone) expectedText haskellText
+compareFormat modUnix fmt zone time = case L.unsnoc fmt of
+    Nothing ->
+        error "compareFormat: The impossible happened! Format string is \"\"."
+    Just (_, lastChar)
+      | lastChar == 'Z' && timeZoneName zone == "" -> rejected
+      | otherwise ->
+            let
+                ctime = utcToZonedTime zone time
+                haskellText = formatTime locale fmt ctime
+                unixText = unixFormatTime fmt zone time
+                expectedText = unixWorkarounds fmt (modUnix unixText)
+            in
+                assertEqualQC (show time ++ " with " ++ show zone) expectedText haskellText
+
+#if !MIN_VERSION_base(4,19,0)
+unsnoc :: [a] -> Maybe ([a], a)
+unsnoc = foldr (\x -> Just . maybe ([], x) (\(~(a, b)) -> (x : a, b))) Nothing
+{-# INLINABLE unsnoc #-}
+#endif
 
 -- as found in http://www.opengroup.org/onlinepubs/007908799/xsh/strftime.html
 -- plus FgGklz