Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add words package to ubuntu CI runs #4530

Open
fendor opened this issue Mar 26, 2025 · 0 comments
Open

Add words package to ubuntu CI runs #4530

fendor opened this issue Mar 26, 2025 · 0 comments
Labels
CI Continuous integration level: easy The issue is suited for beginners type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@fendor
Copy link
Collaborator

fendor commented Mar 26, 2025

In #4527 we noticed the FuzzySearch tests get stuck easily. Turns out, there is a typo in the reference implementation causing it to endlessly loop. For all GHC versions. Why have we never noticed this before?
Well, turns out, the tests are only run if the path /usr/share/dict/words from the words package is installed.
Which it isn't in our CI.

Solution:
We should add this package to our CI, even though these tests add a full minute to our CI time.
Or we delete the test, one of the two 🙃

@fendor fendor added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. CI Continuous integration level: easy The issue is suited for beginners and removed status: needs triage labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration level: easy The issue is suited for beginners type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

1 participant