Follow hlint suggestion: Use elem, Use notElem

Author: philderbeast

.hlint.yaml

@@ -40,7 +40,6 @@
 - ignore: {name: "Use catMaybes"} # 4 hints
 - ignore: {name: "Use concatMap"} # 2 hints
 - ignore: {name: "Use const"} # 37 hints
-- ignore: {name: "Use elem"} # 2 hints
 - ignore: {name: "Use first"} # 5 hints
 - ignore: {name: "Use fmap"} # 24 hints
 - ignore: {name: "Use fold"} # 1 hint
@@ -57,7 +56,6 @@
 - ignore: {name: "Use max"} # 2 hints
 - ignore: {name: "Use maybe"} # 8 hints
 - ignore: {name: "Use newtype instead of data"} # 31 hints
-- ignore: {name: "Use notElem"} # 9 hints
 - ignore: {name: "Use null"} # 2 hints
 - ignore: {name: "Use record patterns"} # 16 hints
 - ignore: {name: "Use replicateM_"} # 2 hints

Cabal-syntax/src/Distribution/Types/PackageId.hs

@@ -65,7 +65,7 @@ instance Parsec PackageIdentifier where
     (v, xs) <- case simpleParsec (NE.last xs') of
       Nothing -> return (nullVersion, toList xs') -- all components are version
       Just v -> return (v, NE.init xs')
-    if not (null xs) && all (\c -> all (/= '.') c && not (all isDigit c)) xs
+    if not (null xs) && all (\c -> notElem '.' c && not (all isDigit c)) xs
       then return $ PackageIdentifier (mkPackageName (intercalate "-" xs)) v
       else fail "all digits or a dot in a portion of package name"
     where

Cabal/src/Distribution/PackageDescription/Check.hs

@@ -423,7 +423,7 @@ checkPackageDescription
     -- But it is OK for executables to have the same name.
     nsubs <- asksCM (pnSubLibs . ccNames)
     checkP
-      (any (== prettyShow pn) (prettyShow <$> nsubs))
+      (elem (prettyShow pn) (prettyShow <$> nsubs))
       (PackageBuildImpossible $ IllegalLibraryName pn)
 
     -- § Fields check.

Cabal/src/Distribution/Simple/Configure.hs

@@ -711,7 +711,7 @@ computeLocalBuildConfig cfg comp programDb = do
             -- rely on them. By the time that bug was fixed, ghci had
             -- been changed to read shared libraries instead of archive
             -- files (see next code block).
-            not (GHC.compilerBuildWay comp `elem` [DynWay, ProfDynWay])
+            notElem (GHC.compilerBuildWay comp) [DynWay, ProfDynWay]
           CompilerId GHCJS _ ->
             not (GHCJS.isDynamic comp)
           _ -> False

Cabal/src/Distribution/Simple/LocalBuildInfo.hs

@@ -320,7 +320,7 @@ depLibraryPaths
     -- because you never have any internal libraries in this case;
     -- they're all external.
     let external_ipkgs = filter is_external (allPackages installed)
-        is_external ipkg = not (installedUnitId ipkg `elem` internalDeps)
+        is_external ipkg = notElem (installedUnitId ipkg) internalDeps
         -- First look for dynamic libraries in `dynamic-library-dirs`, and use
         -- `library-dirs` as a fall back.
         getDynDir pkg = case Installed.libraryDynDirs pkg of

Cabal/src/Distribution/Simple/SrcDist.hs

@@ -428,7 +428,7 @@ filterAutogenModules pkg_descr0 =
     filterFunction bi = \mn ->
       mn /= pathsModule
         && mn /= packageInfoModule
-        && not (mn `elem` autogenModules bi)
+        && notElem mn (autogenModules bi)
 
 -- | Prepare a directory tree of source files for a snapshot version.
 -- It is expected that the appropriate snapshot version has already been set

cabal-install/src/Distribution/Client/CmdInstall.hs

@@ -331,7 +331,7 @@ installCommand =
     }
   where
     -- install doesn't take installDirs flags, since it always installs into the store in a fixed way.
-    notInstallDirOpt x = not $ optionName x `elem` installDirOptNames
+    notInstallDirOpt x = notElem (optionName x) installDirOptNames
     installDirOptNames = map optionName installDirsOptions
 
 -- | The @install@ command actually serves four different needs. It installs:

cabal-install/src/Distribution/Client/CmdUpdate.hs

@@ -179,7 +179,7 @@ updateAction flags@NixStyleFlags{..} extraArgs globalFlags = do
       unless (null updateRepoRequests) $ do
         let remoteRepoNames = map repoName repos
             unknownRepos =
-              [ r | (UpdateRequest r _) <- updateRepoRequests, not (r `elem` remoteRepoNames)
+              [ r | (UpdateRequest r _) <- updateRepoRequests, notElem r remoteRepoNames
               ]
         unless (null unknownRepos) $
           dieWithException verbosity $

cabal-install/src/Distribution/Client/Install.hs

@@ -782,7 +782,7 @@ checkPrintPlan
     -- likely to be broken. We exclude packages that are already broken.
     let newBrokenPkgs =
           filter
-            (\p -> not (Installed.installedUnitId p `elem` excluded))
+            (\p -> notElem (Installed.installedUnitId p) excluded)
             (PackageIndex.reverseDependencyClosure installed reinstalledPkgs)
     let containsReinstalls = not (null reinstalledPkgs)
     let breaksPkgs = not (null newBrokenPkgs)

cabal-install/src/Distribution/Client/Types/AllowNewer.hs

@@ -214,7 +214,7 @@ isRelaxDeps RelaxDepsAll = True
 -- | A smarter 'RelaxedDepsSome', @*:*@ is the same as @all@.
 mkRelaxDepSome :: [RelaxedDep] -> RelaxDeps
 mkRelaxDepSome xs
-  | any (== RelaxedDep RelaxDepScopeAll RelaxDepModNone RelaxDepSubjectAll) xs =
+  | elem (RelaxedDep RelaxDepScopeAll RelaxDepModNone RelaxDepSubjectAll) xs =
       RelaxDepsAll
   | otherwise =
       RelaxDepsSome xs