Use 'MtUnit in Commands returning ()

Author: phadej

CHANGELOG.md

@@ -18,6 +18,8 @@
   [#363](https://github.com/phadej/github/pull/365)
 - Case insensitive enum parsing
   [#373](https://github.com/phadej/github/pull/373)
+- Don't try parse unitary responses
+  [#377](https://github.com/phadej/github/issues/377)
 - Update dependencies
   [#364](https://github.com/phadej/github/pull/364)
   [#368](https://github.com/phadej/github/pull/368)

src/GitHub/Endpoints/Activity/Starring.hs

@@ -91,7 +91,7 @@ unstarRepo auth user repo = executeRequest auth $ unstarRepoR user repo
 
 -- | Unstar a repo by the authenticated user.
 -- See <https://developer.github.com/v3/activity/starring/#unstar-a-repository>
-unstarRepoR :: Name Owner -> Name Repo -> Request 'RW ()
-unstarRepoR user repo = command Delete paths mempty
+unstarRepoR :: Name Owner -> Name Repo -> GenRequest 'MtUnit 'RW ()
+unstarRepoR user repo = Command Delete paths mempty
   where
     paths = ["user", "starred", toPathPart user, toPathPart repo]

src/GitHub/Endpoints/Gists.hs

@@ -81,8 +81,8 @@ unstarGist auth gid = executeRequest auth $ unstarGistR gid
 
 -- | Unstar a gist by the authenticated user.
 -- See <https://developer.github.com/v3/gists/#unstar-a-gist>
-unstarGistR :: Name Gist -> Request 'RW ()
-unstarGistR gid = command Delete ["gists", toPathPart gid, "star"] mempty
+unstarGistR :: Name Gist -> GenRequest 'MtUnit 'RW ()
+unstarGistR gid = Command Delete ["gists", toPathPart gid, "star"] mempty
 
 -- | Delete a gist by the authenticated user.
 --
@@ -92,5 +92,5 @@ deleteGist auth gid = executeRequest auth $ deleteGistR gid
 
 -- | Delete a gist by the authenticated user.
 -- See <https://developer.github.com/v3/gists/#delete-a-gist>
-deleteGistR :: Name Gist -> Request 'RW ()
-deleteGistR gid = command Delete ["gists", toPathPart gid] mempty
+deleteGistR :: Name Gist -> GenRequest 'MtUnit 'RW ()
+deleteGistR gid = Command Delete ["gists", toPathPart gid] mempty

src/GitHub/Endpoints/Issues/Comments.hs

@@ -101,8 +101,8 @@ deleteComment auth user repo commid =
 
 -- | Delete a comment.
 -- See <https://developer.github.com/v3/issues/comments/#delete-a-comment>
-deleteCommentR :: Name Owner -> Name Repo -> Id Comment -> Request 'RW ()
+deleteCommentR :: Name Owner -> Name Repo -> Id Comment -> GenRequest 'MtUnit 'RW ()
 deleteCommentR user repo commid =
-    command Delete parts mempty
+    Command Delete parts mempty
   where
     parts = ["repos", toPathPart user, toPathPart repo, "issues", "comments", toPathPart commid]

src/GitHub/Endpoints/Issues/Labels.hs

@@ -130,9 +130,9 @@ deleteLabel auth user repo lbl =
 
 -- | Delete a label.
 -- See <https://developer.github.com/v3/issues/labels/#delete-a-label>
-deleteLabelR :: Name Owner -> Name Repo -> Name IssueLabel -> Request 'RW ()
+deleteLabelR :: Name Owner -> Name Repo -> Name IssueLabel -> GenRequest 'MtUnit 'RW ()
 deleteLabelR user repo lbl =
-    command Delete ["repos", toPathPart user, toPathPart repo, "labels", toPathPart lbl] mempty
+    Command Delete ["repos", toPathPart user, toPathPart repo, "labels", toPathPart lbl] mempty
 
 -- | The labels on an issue in a repo.
 --
@@ -188,9 +188,9 @@ removeLabelFromIssue auth user repo iid lbl =
 
 -- | Remove a label from an issue.
 -- See <https://developer.github.com/v3/issues/labels/#remove-a-label-from-an-issue>
-removeLabelFromIssueR :: Name Owner -> Name Repo -> Id Issue -> Name IssueLabel -> Request 'RW ()
+removeLabelFromIssueR :: Name Owner -> Name Repo -> Id Issue -> Name IssueLabel -> GenRequest 'MtUnit 'RW ()
 removeLabelFromIssueR user repo iid lbl =
-    command Delete ["repos", toPathPart user, toPathPart repo, "issues", toPathPart iid, "labels", toPathPart lbl] mempty
+    Command Delete ["repos", toPathPart user, toPathPart repo, "issues", toPathPart iid, "labels", toPathPart lbl] mempty
 
 -- | Replace all labels on an issue. Sending an empty list will remove all labels from the issue.
 --
@@ -229,9 +229,9 @@ removeAllLabelsFromIssue auth user repo iid =
 
 -- | Remove all labels from an issue.
 -- See <https://developer.github.com/v3/issues/labels/#remove-all-labels-from-an-issue>
-removeAllLabelsFromIssueR :: Name Owner -> Name Repo -> Id Issue -> Request 'RW ()
+removeAllLabelsFromIssueR :: Name Owner -> Name Repo -> Id Issue -> GenRequest 'MtUnit 'RW ()
 removeAllLabelsFromIssueR user repo iid =
-    command Delete ["repos", toPathPart user, toPathPart repo, "issues", toPathPart iid, "labels"] mempty
+    Command Delete ["repos", toPathPart user, toPathPart repo, "issues", toPathPart iid, "labels"] mempty
 
 -- | All the labels on a repo's milestone given the milestone ID.
 --

src/GitHub/Endpoints/Issues/Milestones.hs

@@ -80,7 +80,7 @@ deleteMilestone auth user repo mid = executeRequest auth $ deleteMilestoneR user
 
 -- | Delete a milestone.
 -- See <https://developer.github.com/v3/issues/milestones/#delete-a-milestone>
-deleteMilestoneR :: Name Owner -> Name Repo -> Id Milestone -> Request 'RW ()
+deleteMilestoneR :: Name Owner -> Name Repo -> Id Milestone -> GenRequest 'MtUnit 'RW ()
 deleteMilestoneR user repo mid =
-    command Delete
+    Command Delete
         ["repos", toPathPart user, toPathPart repo, "milestones", toPathPart mid] mempty

src/GitHub/Endpoints/Organizations/Teams.hs

@@ -124,9 +124,9 @@ deleteTeam' auth tid =
 -- | Delete team.
 --
 -- See <https://developer.github.com/v3/orgs/teams/#delete-team>
-deleteTeamR :: Id Team -> Request 'RW ()
+deleteTeamR :: Id Team -> GenRequest 'MtUnit 'RW ()
 deleteTeamR tid =
-    command Delete ["teams", toPathPart tid] mempty
+    Command Delete ["teams", toPathPart tid] mempty
 
 -- | List team members.
 --
@@ -214,9 +214,9 @@ deleteTeamMembershipFor' auth tid user =
 
 -- | Remove team membership.
 -- See <https://developer.github.com/v3/orgs/teams/#remove-team-membership>
-deleteTeamMembershipForR :: Id Team -> Name Owner -> Request 'RW ()
+deleteTeamMembershipForR :: Id Team -> Name Owner -> GenRequest 'MtUnit 'RW ()
 deleteTeamMembershipForR tid user =
-    command Delete ["teams", toPathPart tid, "memberships", toPathPart user] mempty
+    Command Delete ["teams", toPathPart tid, "memberships", toPathPart user] mempty
 
 -- | List teams for current authenticated user
 --

src/GitHub/Endpoints/Repos.hs

@@ -330,6 +330,8 @@ deleteRepo :: Auth -> Name Owner -> Name Repo -> IO (Either Error ())
 deleteRepo auth user repo =
     executeRequest auth $ deleteRepoR user repo
 
-deleteRepoR :: Name Owner -> Name Repo -> Request 'RW ()
+-- | Delete a repository,.
+-- See <https://developer.github.com/v3/repos/#delete-a-repository>
+deleteRepoR :: Name Owner -> Name Repo -> GenRequest 'MtUnit 'RW ()
 deleteRepoR user repo =
-    command Delete ["repos", toPathPart user, toPathPart repo] mempty
+    Command Delete ["repos", toPathPart user, toPathPart repo] mempty

src/GitHub/Endpoints/Repos/Contents.hs

@@ -166,6 +166,6 @@ deleteFileR
     :: Name Owner
     -> Name Repo
     -> DeleteFile
-    -> Request 'RW ()
+    -> GenRequest 'MtUnit 'RW ()
 deleteFileR user repo body =
-    command Delete ["repos", toPathPart user, toPathPart repo, "contents", deleteFilePath body] (encode body)
+    Command Delete ["repos", toPathPart user, toPathPart repo, "contents", deleteFilePath body] (encode body)

src/GitHub/Endpoints/Repos/DeployKeys.hs

@@ -65,6 +65,6 @@ deleteRepoDeployKey' auth user repo keyId =
 
 -- | Delete a deploy key.
 -- See <https://developer.github.com/v3/repos/keys/#remove-a-deploy-key>
-deleteRepoDeployKeyR :: Name Owner -> Name Repo -> Id RepoDeployKey -> Request 'RW ()
+deleteRepoDeployKeyR :: Name Owner -> Name Repo -> Id RepoDeployKey -> GenRequest 'MtUnit 'RW ()
 deleteRepoDeployKeyR user repo keyId =
-    command Delete ["repos", toPathPart user, toPathPart repo, "keys", toPathPart keyId] mempty
+    Command Delete ["repos", toPathPart user, toPathPart repo, "keys", toPathPart keyId] mempty

src/GitHub/Endpoints/Repos/Webhooks.hs

@@ -103,9 +103,9 @@ deleteRepoWebhook' auth user repo hookId =
 
 -- | Delete a hook.
 -- See <https://developer.github.com/v3/repos/hooks/#delete-a-hook>
-deleteRepoWebhookR :: Name Owner -> Name Repo -> Id RepoWebhook -> Request 'RW ()
+deleteRepoWebhookR :: Name Owner -> Name Repo -> Id RepoWebhook -> GenRequest 'MtUnit 'RW ()
 deleteRepoWebhookR user repo hookId =
-    command Delete (createWebhookOpPath user repo hookId Nothing) mempty
+    Command Delete (createWebhookOpPath user repo hookId Nothing) mempty
 
 createBaseWebhookPath :: Name Owner -> Name Repo -> Id RepoWebhook -> Paths
 createBaseWebhookPath user repo hookId =

src/GitHub/Endpoints/Users/PublicSSHKeys.hs

@@ -78,6 +78,6 @@ deleteUserPublicSSHKey' auth keyId =
 
 -- | Delete a public SSH key.
 -- See <https://developer.github.com/v3/users/keys/#delete-a-public-key>
-deleteUserPublicSSHKeyR :: Id PublicSSHKey -> Request 'RW ()
+deleteUserPublicSSHKeyR :: Id PublicSSHKey -> GenRequest 'MtUnit 'RW ()
 deleteUserPublicSSHKeyR keyId =
-    command Delete ["user", "keys", toPathPart keyId] mempty
+    Command Delete ["user", "keys", toPathPart keyId] mempty

src/GitHub/Request.hs

@@ -331,8 +331,10 @@ parseStatus m (Status sci _) =
 -- Unit
 -------------------------------------------------------------------------------
 
+-- | Note: we don't ignore response status.
+--
+-- We only accept any response body.
 instance Accept 'MtUnit where
-    modifyRequest = Tagged setRequestIgnoreStatus
 
 instance a ~ () => ParseResponse 'MtUnit a where
     parseResponse _ _ = Tagged (return ())