Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing CloseMessage event #9

Open
pgjones opened this issue Dec 30, 2018 · 0 comments
Open

Missing CloseMessage event #9

pgjones opened this issue Dec 30, 2018 · 0 comments

Comments

@pgjones
Copy link

pgjones commented Dec 30, 2018

I think this should send a CloseMessage frame before closing the connection, rather than just sending an EOF as at the moment. I think s.ws.WriteMessage(websocket.CloseMessage, []byte{}) in the error handling part of readConsole would do this, but my go isn't good enough for me to be sure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgjones