-
Notifications
You must be signed in to change notification settings - Fork 24
Description
Based on a previous issue I opened last year, I believe this repo is a recent one consolidating private and internal repositories, which is great 🙌 Therefore, the team is probably super busy to hook and set things up.
However, being a public repo (and not having the background knowledge about the consolidation) makes people wanna contribute. Even I myself couldn't resist opening a few small PRs (and a whole lot in my to-do list).
Take this one liner, which has been open for more than a week, as an example. I doubt the content changed in that PR is what takes a week to review, and rather the team is in the middle of the consolidation and not ready for public contribution?
The thing with these one-liner PRs is that the change itself is not worth merge conflicts (which happens the longer they are kept open), especially when the files are renamed/moved, in which case it's probably quicker to close the PR and raise a new one (which I probably wouldn't bother at that stage).
To be honest, I've started reading the docs cover to cover (again) to prepare for the Terraform Associate Certification exam. So, I'm probably one of the fewest resources out there that can fix a great deal of typos and formatting hiccups across the board free of charge 😅
So, I'm wondering which one of the following the team prefers:
- Don't accept public contribution at all
- Delay public contribution until the consolidation is complete
- Define processes internally to review non-controversial PRs (one liners and formatting fixes), and delay more complex content changes until after the consolidation
- Something else?
Regardless, it would be great to have a message about it in the README file so that public contributors hold appropriate expectations around opening PRs and the review turnaround time.