Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic modules generates conditions in all IAM resources #14284

Closed
trodge opened this issue Apr 11, 2023 · 4 comments
Closed

Magic modules generates conditions in all IAM resources #14284

trodge opened this issue Apr 11, 2023 · 4 comments

Comments

@trodge
Copy link
Collaborator

trodge commented Apr 11, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.4.2

Affected Resource(s)

google_*_iam_binding
google_*_iam_member

Only these resources should have a condition field in their iam binding and member resources, but currently all binding and member resources have this field.

@rileykarson
Copy link
Collaborator

Marking size/L due to needing to verify which ones are correct / which aren't

@rileykarson
Copy link
Collaborator

Talking about this in fixit kickoff- we're not sure how to verify which resources support conditions. We don't especially trust central lists of these things (they're often out of date) but individual resource pages are also often wrong.

@melinath
Copy link
Collaborator

duplicate of #18412

@melinath melinath closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants