From 3bd1b8d787d63e79ff07de1a8ad51aeb15fe5a0b Mon Sep 17 00:00:00 2001 From: Mutahhir Hayat Date: Thu, 23 Nov 2023 09:48:22 +0100 Subject: [PATCH] fix: Use unique names to see if Github filters can pick it up (#3291) ### Description Part of the Merge queue running the required checks, Github UI is still not picking up the results job so try 2 --- .github/workflows/examples-pr.yml | 4 ++-- .github/workflows/pr-integration.yml | 2 +- .github/workflows/pr-provider-integration.yml | 2 +- .github/workflows/pr-unit.yml | 16 +++++++++++++--- 4 files changed, 17 insertions(+), 7 deletions(-) diff --git a/.github/workflows/examples-pr.yml b/.github/workflows/examples-pr.yml index 363f11ab94..24a514be44 100644 --- a/.github/workflows/examples-pr.yml +++ b/.github/workflows/examples-pr.yml @@ -13,7 +13,7 @@ on: jobs: examples: - name: "Examples Integration Test - PR" + name: "Examples Integration Tests - PR" if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci/skip-examples') && !contains(github.event.pull_request.labels.*.name, 'ci/unit-only') }} uses: ./.github/workflows/examples.yml with: @@ -22,7 +22,7 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Result + name: "Examples Integration Tests - PR - Result" needs: [examples] steps: - run: exit 1 diff --git a/.github/workflows/pr-integration.yml b/.github/workflows/pr-integration.yml index 29b3a11728..1aed1a4e6b 100644 --- a/.github/workflows/pr-integration.yml +++ b/.github/workflows/pr-integration.yml @@ -22,7 +22,7 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Result + name: "Integration Tests - PR - Result" needs: [integration_test] steps: - run: exit 1 diff --git a/.github/workflows/pr-provider-integration.yml b/.github/workflows/pr-provider-integration.yml index 679979893e..c02ce4a8e6 100644 --- a/.github/workflows/pr-provider-integration.yml +++ b/.github/workflows/pr-provider-integration.yml @@ -22,7 +22,7 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Result + name: "Provider Integration Tests - PR - Result" needs: [provider_integration_test] steps: - run: exit 1 diff --git a/.github/workflows/pr-unit.yml b/.github/workflows/pr-unit.yml index ff88caf604..fd569927cc 100644 --- a/.github/workflows/pr-unit.yml +++ b/.github/workflows/pr-unit.yml @@ -14,7 +14,7 @@ on: jobs: all_unit_tests: name: "All Unit Tests" - if: ${{ contains(github.event.pull_request.labels.*.name, 'ci/run-unit') || contains(github.event.pull_request.labels.*.name, 'ci/run-all') }} + if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci/skip-unit') }} uses: ./.github/workflows/unit.yml strategy: fail-fast: false @@ -138,8 +138,18 @@ jobs: results: if: ${{ always() }} runs-on: ubuntu-latest - name: Result - needs: [all_unit_tests] + name: Unit Tests - PR - Result + needs: + [ + all_unit_tests, + cdktf, + cdktf_cli, + cdktf_provider_generator, + cdktf_hcl2json, + cdktf_hcl2cdk, + cdktf_commons, + cdktf_cli_core, + ] steps: - run: exit 1 if: >-