Skip to content

Commit 9c54d11

Browse files
committed
fixed some issues with how the “extra” themed CSS files were generated
1 parent b84ec98 commit 9c54d11

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

packages/tokens/scripts/build-parts/generateExtraThemingFiles.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,10 @@ export async function generateExtraThemingFiles(_dictionary: Dictionary, config:
2929
// CSS file for `prefers-color-scheme` (note: we use `cds-g0` for `light` and `cds-g100` for `dark`
3030
if (method === 'prefers-color-scheme') {
3131
outputContent = `${header}\n\n`;
32+
//
33+
// these are the themed `carbonized` tokens
3234
outputContent += `@media (prefers-color-scheme: dark) { ${cds0ThemedSource} }\n\n`;
3335
outputContent += `@media (prefers-color-scheme: light) { ${cds100ThemedSource} }\n\n`;
34-
// this is the fallback to `light` mode
35-
// commented for now: consumers can always import the `themed-tokens/with-root-selector/cds-g0/themed-tokens.css` as extra file if they want to
36-
// outputContent += '\n\n';
37-
// outputContent += `${cds0ThemedSource}\n\n`;
3836
//
3937
// this is the common part
4038
outputContent += `${commonSource}\n\n`;
@@ -43,34 +41,36 @@ export async function generateExtraThemingFiles(_dictionary: Dictionary, config:
4341
// CSS file for `.class/[data]` selectors
4442
if (method === 'css-selectors') {
4543
outputContent = `${header}\n\n`;
46-
outputContent += `${hdsThemedSource.replace(/^:root/, '.hds-theme-default, [data-hds-theme="default"]')}\n\n`;
44+
//
45+
// this is the fallback to the default `hds` mode
46+
outputContent += `${hdsThemedSource}\n\n`;
47+
//
48+
// these are the themed `carbonized` tokens
4749
outputContent += `${cds0ThemedSource.replace(/^:root/, '.hds-theme-cds-g0, [data-hds-theme="cds-g0"]')}\n\n`;
4850
outputContent += `${cds10ThemedSource.replace(/^:root/, '.hds-theme-cds-g10, [data-hds-theme="cds-g10"]')}\n\n`;
4951
outputContent += `${cds90ThemedSource.replace(/^:root/, '.hds-theme-cds-g90, [data-hds-theme="cds-g90"]')}\n\n`;
5052
outputContent += `${cds100ThemedSource.replace(/^:root/, '.hds-theme-cds-g100, [data-hds-theme="cds-g100"]')}\n\n`;
5153
//
52-
// this is the fallback to the default `hds` mode
53-
outputContent += `${hdsThemedSource}\n\n`;
54-
//
5554
// this is the common part
5655
outputContent += `${commonSource}\n\n`;
5756
}
5857

5958
// CSS file for combined `prefers-color-scheme` and CSS selectors in the same file
6059
if (method === 'combined-strategies') {
6160
outputContent = `${header}\n\n`;
62-
// we will revisit the `[class*=hds-theme-]` selector if we find that is too generic and there are cases where this is picking up other classes
61+
//
62+
// this is the fallback to the default `hds` mode
63+
outputContent += `${hdsThemedSource}\n\n`;
64+
//
65+
// these are the themed `carbonized` tokens
66+
// note: we will revisit the `[class*=hds-theme-]` selector if we find that is too generic and there are cases where this is picking up other classes
6367
outputContent += `@media (prefers-color-scheme: dark) { ${cds0ThemedSource.replace(/^:root/, ':root:not([class*=hds-theme-]):not([data-hds-theme])')} }\n\n`;
6468
outputContent += `@media (prefers-color-scheme: light) { ${cds100ThemedSource.replace(/^:root/, ':root:not([class*=hds-theme-]):not([data-hds-theme])')} }\n\n`;
65-
outputContent += `${hdsThemedSource.replace(/^:root/, '.hds-theme-default, [data-hds-theme="default"]')}\n\n`;
6669
outputContent += `${cds0ThemedSource.replace(/^:root/, '.hds-theme-cds-g0, [data-hds-theme="cds-g0"]')}\n\n`;
6770
outputContent += `${cds10ThemedSource.replace(/^:root/, '.hds-theme-cds-g10, [data-hds-theme="cds-g10"]')}\n\n`;
6871
outputContent += `${cds90ThemedSource.replace(/^:root/, '.hds-theme-cds-g90, [data-hds-theme="cds-g90"]')}\n\n`;
6972
outputContent += `${cds100ThemedSource.replace(/^:root/, '.hds-theme-cds-g100, [data-hds-theme="cds-g100"]')}\n\n`;
7073
//
71-
// this is the fallback to the default `hds` mode
72-
outputContent += `${hdsThemedSource}\n\n`;
73-
//
7474
// this is the common part
7575
outputContent += `${commonSource}\n\n`;
7676
}

0 commit comments

Comments
 (0)