Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize requests/limits for init and cleanup jobs. #4407

Open
aidanestes opened this issue Oct 23, 2024 · 0 comments
Open
Labels
type/enhancement New feature or request

Comments

@aidanestes
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

Many of the Kubernetes Jobs that are installed with Helm hooks (e.g., post-install, pre-delete, etc.) have hardcoded resource requests and limits. For instance:

Other jobs have the ability to customize these requests and limits:

On some of my Kubernetes environments where I install this Consul Helm chart, I get OOMKilled events on the Jobs with hardcoded requests and limits, blocking operations like Helm deletes, Helm installs, and Helm upgrades.

I can workaround this issue by installing Kyverno on the cluster and using a ClusterPolicy to mutate the resource requests and limits for these Jobs upon admission to the cluster, but I should not have to depend on Kyverno mutating policies to configure Consul properly in my clusters.

Feature Description

I would request you expose values in your Helm chart to allow me to customize the resource requests and limits for Jobs installed by the Chart.

Use Case(s)

All cases. This is fundamental to the management of the chart with Helm.

Contributions

I can contribute with a PR if desired. This is a small, low-risk change.

@aidanestes aidanestes added the type/enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant