From d03710f51f95a183d3cdbb02a61e030181755da8 Mon Sep 17 00:00:00 2001
From: Rebecca Cremona <rcremona@law.harvard.edu>
Date: Fri, 8 Dec 2023 12:46:16 -0500
Subject: [PATCH] Remove unused utilities.

---
 developer.md                | 16 ++++++++++------
 perma_web/tasks/__init__.py |  3 +--
 perma_web/tasks/dev.py      | 26 --------------------------
 update.sh                   |  6 ------
 4 files changed, 11 insertions(+), 40 deletions(-)
 delete mode 100644 update.sh

diff --git a/developer.md b/developer.md
index 491caa73d..02d4dff4f 100644
--- a/developer.md
+++ b/developer.md
@@ -70,7 +70,8 @@ Press `CONTROL-C` to stop the server.
 
 ### Run the tests
 
-`d invoke test`
+`d pytest`
+`d npm test`
 
 See [Testing and Test Coverage](#testing-and-test-coverage) for more
 information about testing Perma.
@@ -102,9 +103,14 @@ To upgrade a single requirement to the latest version:
 
 ### Update the node dependencies
 
-Make your changes in `packages.json`. Then run `update.sh`, a convenience
-script that will create a new `npm-shrinkwrap.json` and will rebuild the
-Docker image with the new dependencies installed.
+Install new packages: `d npm install --save-dev package_name`
+Uninstall new packages: `d npm uninstall package_name`
+
+Update a single package:
+- if necessary, change the pinned version in package.json
+- `d npm update package_name`
+
+Update all dependencies: ``
 
 ### Migrate the database
 
@@ -293,8 +299,6 @@ Javascript tests live in `spec/`.
 See the [Common tasks and commands](#common-tasks-and-commands) for the
 common techniques for running the tests.
 
-The `d invoke test` command also generates handy coverage information. You can access it by running `d coverage report`.
-
 
 ### Linting with flake8
 
diff --git a/perma_web/tasks/__init__.py b/perma_web/tasks/__init__.py
index 76d9d67cf..455c04b6d 100644
--- a/perma_web/tasks/__init__.py
+++ b/perma_web/tasks/__init__.py
@@ -12,11 +12,10 @@
     print(f"WARNING: Can't configure Django. {e}")
 
 # import sub-tasks
-from .dev import run, test, pip_compile
+from .dev import run, pip_compile
 from . import dev
 
 ns = Collection()
 ns.add_task(run)
-ns.add_task(test)
 ns.add_task(pip_compile)
 ns.add_collection(dev)
diff --git a/perma_web/tasks/dev.py b/perma_web/tasks/dev.py
index 20977e3c7..39beb4ff8 100644
--- a/perma_web/tasks/dev.py
+++ b/perma_web/tasks/dev.py
@@ -72,32 +72,6 @@ def run(ctx, port="0.0.0.0:8000", cert_file='perma-test.crt', key_file='perma-te
                 os.kill(proc.pid, signal.SIGKILL)
 
 
-_default_tests = "functional_tests perma api lockss"
-
-@task
-def test(ctx, apps=_default_tests):
-    """ Run perma tests. (For coverage, run `coverage report` after tests pass.) """
-    test_python(ctx, apps)
-    if apps == _default_tests:
-        test_js(ctx)
-
-@task
-def test_python(ctx, apps=_default_tests):
-    """ Run Python tests. """
-
-    # In order to run functional_tests, we have to run collectstatic, since functional tests use DEBUG=False
-    # For speed we use the default Django STATICFILES_STORAGE setting here, which also has to be set in settings_testing.py
-    if "functional_tests" in apps:
-        ctx.run("DJANGO__STATICFILES_STORAGE=django.contrib.staticfiles.storage.StaticFilesStorage python manage.py collectstatic --noinput")
-
-    ctx.run(f"pytest {apps} --ds=perma.settings.deployments.settings_testing --cov --cov-config=setup.cfg --cov-report= ")
-
-@task
-def test_js(ctx):
-    """ Run Javascript tests. """
-    ctx.run("npm test")
-
-
 @task
 def pip_compile(ctx, args=''):
     # run pip-compile
diff --git a/update.sh b/update.sh
deleted file mode 100644
index 3ee0bfc9a..000000000
--- a/update.sh
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/usr/bin/env bash
-
-docker-compose exec web npm shrinkwrap --dev
-docker-compose exec web invoke pip-compile
-docker-compose up -d --build
-printf "\n\nYour image has been updated."