Skip to content

Commit d58f4ae

Browse files
committed
docs(hm-core): TODO to return Url from api_url/app_url when the SDK allows
The harmont-cloud client string-concatenates its base (format!("{base}{path}")), so BackendDomain must hand back a trailing-slash-trimmed String. Note to switch to Url once the client accepts a URL base.
1 parent 1ca9926 commit d58f4ae

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎crates/hm-core/src/config/domain.rs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ impl BackendDomain {
4949
Ok(Self(Url::parse(&normalized)?))
5050
}
5151

52+
// TODO: return `Url` from api_url()/app_url() once the harmont-cloud client
53+
// accepts a URL base instead of string-concatenating (`format!("{base}{path}")`).
54+
// Its naive concat is why these must hand back a trailing-slash-trimmed String.
55+
5256
/// The API base URL (`https://api.<domain>`), without a trailing slash.
5357
#[must_use]
5458
pub fn api_url(&self) -> String {

0 commit comments

Comments
 (0)