Skip to content

Commit c908c5c

Browse files
jpeirsonJeff Peirson
and
Jeff Peirson
authored
Adds SecurityDetails.subjectAlternativeNames (#2820)
* Adds SecurityDetails.subjectAlternativeNames which is part of the Puppeteer API but not yet in PuppeterSharp * Patch version bump --------- Co-authored-by: Jeff Peirson <[email protected]>
1 parent 874c78d commit c908c5c

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

lib/PuppeteerSharp/PuppeteerSharp.csproj

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
<Description>Headless Browser .NET API</Description>
1313
<PackageId>PuppeteerSharp</PackageId>
1414
<PackageReleaseNotes></PackageReleaseNotes>
15-
<PackageVersion>20.0.4</PackageVersion>
16-
<ReleaseVersion>20.0.4</ReleaseVersion>
17-
<AssemblyVersion>20.0.4</AssemblyVersion>
18-
<FileVersion>20.0.4</FileVersion>
15+
<PackageVersion>20.0.5</PackageVersion>
16+
<ReleaseVersion>20.0.5</ReleaseVersion>
17+
<AssemblyVersion>20.0.5</AssemblyVersion>
18+
<FileVersion>20.0.5</FileVersion>
1919
<SynchReleaseVersion>false</SynchReleaseVersion>
2020
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
2121
<DebugType>embedded</DebugType>

lib/PuppeteerSharp/SecurityDetails.cs

+21
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,27 @@ public SecurityDetails()
2222
/// <param name="validTo">Valid to.</param>
2323
/// <param name="protocol">Protocol.</param>
2424
public SecurityDetails(string subjectName, string issuer, long validFrom, long validTo, string protocol)
25+
: this(subjectName, issuer, validFrom, validTo, protocol, [])
26+
{
27+
}
28+
29+
/// <summary>
30+
/// Initializes a new instance of the <see cref="SecurityDetails"/> class.
31+
/// </summary>
32+
/// <param name="subjectName">Subject name.</param>
33+
/// <param name="issuer">Issuer.</param>
34+
/// <param name="validFrom">Valid from.</param>
35+
/// <param name="validTo">Valid to.</param>
36+
/// <param name="protocol">Protocol.</param>
37+
/// <param name="subjectAlternativeNames">Subject alternative names.</param>
38+
public SecurityDetails(string subjectName, string issuer, long validFrom, long validTo, string protocol, string[] subjectAlternativeNames)
2539
{
2640
SubjectName = subjectName;
2741
Issuer = issuer;
2842
ValidFrom = validFrom;
2943
ValidTo = validTo;
3044
Protocol = protocol;
45+
SubjectAlternativeNames = subjectAlternativeNames;
3146
}
3247

3348
/// <summary>
@@ -59,5 +74,11 @@ public SecurityDetails(string subjectName, string issuer, long validFrom, long v
5974
/// </summary>
6075
/// <value>The protocol.</value>
6176
public string Protocol { get; set; }
77+
78+
/// <summary>
79+
/// Gets the list of subject alternative names (SANs) of the certificate.
80+
/// </summary>
81+
/// <value>The list of subject alternative names (SANs) of the certificate.</value>
82+
public string[] SubjectAlternativeNames { get; set; }
6283
}
6384
}

0 commit comments

Comments
 (0)