Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

Commit a361847

Browse files
akanassakanass
authored
Merge pull request #14 from hapinessjs/next
release(version): v6.4.2 to fix angular/angular#26128 and angular/angular#25813
2 parents e67bc1c + bb25de6 commit a361847

File tree

7 files changed

+404
-518
lines changed

7 files changed

+404
-518
lines changed

‎package.json‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@hapiness/ng-elements-loader-cli",
3-
"version": "6.4.1",
3+
"version": "6.4.2",
44
"description": "Angular CLI project to manage @hapiness/ng-elements-loader and @hapiness/custom-elements-loader projects",
55
"scripts": {
66
"build:ng": "ng build 'ng-elements-loader' --prod",
@@ -34,32 +34,32 @@
3434
"url": "https://github.com/hapinessjs/ng-elements-loader/issues"
3535
},
3636
"dependencies": {
37-
"@angular/common": "6.1.7",
38-
"@angular/core": "6.1.7",
39-
"@angular/compiler": "6.1.7",
40-
"@angular/animations": "6.1.7",
41-
"@angular/elements": "6.1.7",
42-
"@angular/platform-browser": "6.1.7",
43-
"@angular/platform-browser-dynamic": "6.1.7",
37+
"@angular/common": "^6.1.10",
38+
"@angular/core": "^6.1.10",
39+
"@angular/compiler": "^6.1.10",
40+
"@angular/animations": "^6.1.10",
41+
"@angular/elements": "^6.1.10",
42+
"@angular/platform-browser": "^6.1.10",
43+
"@angular/platform-browser-dynamic": "^6.1.10",
4444
"core-js": "^2.5.7",
4545
"document-register-element": "~1.8.1",
4646
"rxjs": "^6.3.3",
4747
"zone.js": "^0.8.26"
4848
},
4949
"devDependencies": {
50-
"@angular/compiler-cli": "6.1.7",
51-
"@angular-devkit/build-ng-packagr": "~0.8.3",
52-
"@angular-devkit/build-angular": "~0.8.3",
53-
"ng-packagr": "^4.2.0",
50+
"@angular/compiler-cli": "^6.1.10",
51+
"@angular-devkit/build-ng-packagr": "~0.8.5",
52+
"@angular-devkit/build-angular": "~0.8.5",
53+
"ng-packagr": "^4.3.1",
5454
"tsickle": "^0.33.0",
5555
"tslib": "^1.9.3",
5656
"typescript": "~2.9.2",
57-
"@angular/cli": "^6.2.3",
58-
"@angular/language-service": "6.1.7",
57+
"@angular/cli": "^6.2.5",
58+
"@angular/language-service": "^6.1.10",
5959
"@types/jasmine": "~2.8.8",
6060
"@types/jasminewd2": "~2.0.3",
61-
"@types/node": "~10.11.0",
62-
"codelyzer": "~4.4.4",
61+
"@types/node": "~10.12.0",
62+
"codelyzer": "~4.5.0",
6363
"jasmine-core": "~3.2.1",
6464
"jasmine-spec-reporter": "~4.2.1",
6565
"karma": "~3.0.0",

‎projects/custom-elements-loader/README.md‎

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ The minimum `package.json` file for your module is described below:
183183
"name": "made-with-love",
184184
"version": "1.0.0",
185185
"peerDependencies": {
186-
"@hapiness/custom-elements-loader": "^6.4.0"
186+
"@hapiness/custom-elements-loader": "^6.4.2"
187187
}
188188
}
189189
```
@@ -235,6 +235,8 @@ We create a `HTML`file with our `custom element` inside.
235235
// POLYFILLS
236236
import 'zone.js/dist/zone';
237237
import 'document-register-element';
238+
import 'core-js/es6/reflect';
239+
import 'core-js/es7/reflect';
238240

239241
import { ElementsLoader } from '@hapiness/custom-elements-loader';
240242
import { MadeWithLoveModule } from 'made-with-love';
@@ -262,6 +264,8 @@ Loading of the component happens inside `main.ts` file.
262264
```typescript
263265
import 'zone.js/dist/zone';
264266
import 'document-register-element';
267+
import 'core-js/es6/reflect';
268+
import 'core-js/es7/reflect';
265269
```
266270

267271
- Additional **polyfills** can be added if needed:
@@ -286,8 +290,12 @@ import 'document-register-element';
286290
/** IE10 and IE11 requires the following for NgClass support on SVG elements */
287291
// import 'classlist.js'; // Run `npm install --save classlist.js`.
288292

289-
/** IE10 and IE11 requires the following for the Reflect API. */
290-
// import 'core-js/es6/reflect';
293+
/**
294+
* Web Animations `@angular/platform-browser/animations`
295+
* Only required if AnimationBuilder is used within the application and using IE/Edge or Safari.
296+
* Standard animation support in Angular DOES NOT require any polyfills (as of Angular 6.0).
297+
**/
298+
// import 'web-animations-js'; // Run `npm install --save web-animations-js`.
291299
```
292300

293301

@@ -391,6 +399,8 @@ We set a **listener** to catch `sayHello` event and do what we want:
391399
// POLYFILLS
392400
import 'zone.js/dist/zone';
393401
import 'document-register-element';
402+
import 'core-js/es6/reflect';
403+
import 'core-js/es7/reflect';
394404

395405
import { ElementsLoader } from '@hapiness/custom-elements-loader';
396406
import { HelloWorldModule } from 'hello-world';
@@ -408,6 +418,11 @@ document.querySelector('hello-world').addEventListener('sayHello', (event: any)
408418
[Back to top](#installation)
409419

410420
## Change History
421+
* v6.4.2 (2018-10-18)
422+
* `Angular v6.1.10+`
423+
* Explain how to add new polyfills for `reflect api` to solve bug reported in this [issue](https://github.com/angular/angular/issues/26128)
424+
* Provide `ElementsLoaderService` in `ElementsLoaderModule` to solve bug reported in this [issue](https://github.com/angular/angular/issues/25813)
425+
* Documentation
411426
* v6.4.1 (2018-09-26)
412427
* Fix version to `Angular v6.1.7` to avoid the bug reported in this [issue](https://github.com/angular/angular/issues/26128)
413428
* Documentation

‎projects/custom-elements-loader/package.json‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@hapiness/custom-elements-loader",
3-
"version": "6.4.1",
3+
"version": "6.4.2",
44
"description": "Factory to load Angular Custom Elements inside JavaScript's applications like React.js, Vue.js or just standalone",
55
"private": false,
66
"repository": {
@@ -30,14 +30,14 @@
3030
"url": "https://github.com/hapinessjs/ng-elements-loader/issues"
3131
},
3232
"dependencies": {
33-
"@angular/animations": "6.1.7",
34-
"@angular/common": "6.1.7",
35-
"@angular/core": "6.1.7",
36-
"@angular/compiler": "6.1.7",
37-
"@angular/elements": "6.1.7",
38-
"@angular/platform-browser": "6.1.7",
39-
"@angular/platform-browser-dynamic": "6.1.7",
40-
"@hapiness/ng-elements-loader": "^6.4.1",
33+
"@angular/animations": "^6.1.10",
34+
"@angular/common": "^6.1.10",
35+
"@angular/core": "^6.1.10",
36+
"@angular/compiler": "^6.1.10",
37+
"@angular/elements": "^6.1.10",
38+
"@angular/platform-browser": "^6.1.10",
39+
"@angular/platform-browser-dynamic": "^6.1.10",
40+
"@hapiness/ng-elements-loader": "^6.4.2",
4141
"core-js": "^2.5.7",
4242
"document-register-element": "~1.8.1",
4343
"rxjs": "^6.3.3",

‎projects/custom-elements-loader/src/lib/elements-loader.module.ts‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
44
import { ElementsLoaderService } from '@hapiness/ng-elements-loader';
55

66
@NgModule({
7-
imports: [
8-
BrowserAnimationsModule
9-
]
7+
imports: [ BrowserAnimationsModule ],
8+
providers: [ ElementsLoaderService ]
109
})
1110
export class ElementsLoaderModule {
12-
constructor(private _elementsLoaderService: ElementsLoaderService) {}
13-
ngDoBootstrap() {}
11+
ngDoBootstrap() {
12+
}
1413
}

‎projects/ng-elements-loader/README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,9 @@ this._rd.listen(element, 'sayHello', (event: any) => this.alertHello(event.detai
406406
[Back to top](#installation)
407407

408408
## Change History
409+
* v6.4.2 (2018-10-18)
410+
* `Angular v6.1.10+`
411+
* Documentation
409412
* v6.4.1 (2018-09-26)
410413
* Fix version to `Angular v6.1.7` to avoid the bug reported in this [issue](https://github.com/angular/angular/issues/26128)
411414
* Documentation

‎projects/ng-elements-loader/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@hapiness/ng-elements-loader",
3-
"version": "6.4.1",
3+
"version": "6.4.2",
44
"description": "Service to load Angular Custom Elements inside Angular's applications",
55
"private": false,
66
"repository": {
@@ -27,12 +27,12 @@
2727
"url": "https://github.com/hapinessjs/ng-elements-loader/issues"
2828
},
2929
"peerDependencies": {
30-
"@angular/common": "6.1.7",
31-
"@angular/core": "6.1.7",
32-
"@angular/compiler": "6.1.7",
33-
"@angular/elements": "6.1.7",
34-
"@angular/platform-browser": "6.1.7",
35-
"@angular/platform-browser-dynamic": "6.1.7",
30+
"@angular/common": "^6.1.10",
31+
"@angular/core": "^6.1.10",
32+
"@angular/compiler": "^6.1.10",
33+
"@angular/elements": "^6.1.10",
34+
"@angular/platform-browser": "^6.1.10",
35+
"@angular/platform-browser-dynamic": "^6.1.10",
3636
"core-js": "^2.5.7",
3737
"document-register-element": "~1.8.1",
3838
"rxjs": "^6.3.3",

0 commit comments

Comments
 (0)