Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build badge in readme to show the build workflow status instead of test #1443

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Update build badge in readme to show the build workflow status instead of test #1443

merged 3 commits into from
Sep 3, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Sep 3, 2024 •
edited
Loading

Context

The badge in our readme file shows build: failing because of #1430. It is misleading because the build workflow works fine. It's only the browser tests that are broken.

This PR changes the badge to report the status of the build workflow instead of the test workflow.

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Performance comparison of head (9d4ac52) vs base (67bae9e)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 515.48 | 518.98 | +0.68%
                                      Sheet B | 166.93 | 169.44 | +1.50%
                                      Sheet T | 147.84 | 149.42 | +1.07%
                                Column ranges | 514.89 | 526.32 | +2.22%
Sheet A:  change value, add/remove row/column |  15.33 |  16.03 | +4.57%
 Sheet B: change value, add/remove row/column | 133.09 | 137.52 | +3.33%
                   Column ranges - add column | 158.24 | 162.22 | +2.52%
                Column ranges - without batch | 458.63 | 479.33 | +4.51%
                        Column ranges - batch |  114.8 | 123.21 | +7.33%

@sequba sequba self-assigned this Sep 3, 2024
@sequba sequba added Docs Improvements or additions to documentation Impact: High labels Sep 3, 2024
@sequba sequba merged commit fa09de2 into develop Sep 3, 2024
20 of 22 checks passed
@sequba sequba deleted the feature/update-readme-build-badge branch September 3, 2024 13:40
sequba added a commit that referenced this pull request Sep 4, 2024
@sequba
Update build badge in readme to show the build workflow status instea…
0c2e214 
…d of test (#1443)

* Update build badge to show the build workflow status instead of test
@sequba sequba mentioned this pull request Sep 4, 2024
Merged
13 tasks
sequba added a commit that referenced this pull request Sep 4, 2024
@sequba
Fix readme build badge (hotfix to master) (#1445)
b89d2ce 
* Use Node 20 in all the build/test workflows (#1435)

* Update build badge in readme to show the build workflow status instead of test (#1443)

* Update build badge to show the build workflow status instead of test

* Add build-docs workflow (#1434)

* Add build-docs workflow

* Add environment variables necessary to build the docs with Node 20
sequba added a commit that referenced this pull request Nov 6, 2024
@sequba
Deploy documentation with native HTML+JS demos (#1441) (#1454)
76aaae5 
* Merge hotfix to develop (#1431)

Change publish-docs workflow to use Node 20 instead of 22 due to the temporary npm issue

* Merge hotfix to develop (#1432)

* Change publish-docs workflow to use Node 20 instead of 22 due to the temporary npm issue (#1424)

* Set NODE_OPTIONS=--openssl-legacy-provider for the typedoc command

* Merge hotfix to develop (#1433)

* Change publish-docs workflow to use Node 20 instead of 22 due to the temporary npm issue (#1424)

* Hotfix: Set NODE_OPTIONS=--openssl-legacy-provider for the typedoc command (#1425)

Set NODE_OPTIONS=--openssl-legacy-provider for the typedoc command

* Revert the publish-docs workflow to Node 16

* Add build-docs workflow (#1434)

* Add build-docs workflow

* Add environment variables necessary to build the docs with Node 20

* Use Node 20 in all the build/test workflows (#1435)

* Remove license comments from the UMD build (#1437)

* Install terser plugin explicite to enable extensive customization

* Remove license comment from the UMD builds using string-replace-loader webpack plugin

* Test for the redundant license comments in the UMD build inside the verify:umd script

* Update build badge in readme to show the build workflow status instead of test (#1443)

* Update build badge to show the build workflow status instead of test

* Native demos in the docs (#1447)

* Add markdown-it plugins

* Make HTML+CSS preview work

* Make some of the buttons work

* Add edit-in-stackblitz button

* Make the entire runtime of the demo work (including js)

* Add real HF demo.

* Make HyperFormula import work in runtime of the docs examples

* Add script code-examples-generator

* Style stackblitz button

* Style demo internal buttons

* Remove unused glue-code

* Remove not needed vuepress plugins

* Fix linter error

* Reformat demo/example1.ts file

* Add advanced-usage demo

* Change the framework demos in the docs to use Codesandbox iframe instead of Stackblitz

* Add basic-operations demo

* Add basic-usage demo

* Add batch-operations demo

* Add demo clipboard-operations

* Changed the custom-functions demo to use Codesandbox instead of Stackblitz

* Add date-time demo

* Add demo i18n

* Add localizing-functions guide

* Add named-expressions demo

* Add sorting-data demo

* Add undo-redo demo

* Fix lint errors

* Disable linter for the docs examples

* Tweak the styling of demo example

* Fix row and column counting in the docs examples

* Adjust css of basic-usage demo

* Adjust style of advanced-usage demo

* Fix styles for basic-operations demo

* Fix styles for batch-operations demo

* Fix styles for sorting demo

* Fix height of the table cell in the demos

* Adjust text decoration of the summary row in the i18n demo

* Fix styles for basic-operations demo

* Adjust styles for the inputs

* Disable logging HF version to console in the native examples embedded in the docs

* Update styles for the open-in-stackblitz button

* Fix broken favicon link

* Fix examples.js script to handle newline characters in both unix and windows styles

* Reduce space between buttons and table in the undo-redo demo

* Fix style for checkbox in the batch-operations demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sequba sequba

Labels
Docs Improvements or additions to documentation Impact: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sequba