Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about joins in hanami/rom #309

Open
davydovanton opened this issue Apr 6, 2017 · 6 comments
Open

Add information about joins in hanami/rom #309

davydovanton opened this issue Apr 6, 2017 · 6 comments

Comments

@davydovanton
Copy link
Member

davydovanton commented Apr 6, 2017

I think it's an important theme for guides. That's why I suggest to add this. We can use this SO question for example:
https://stackoverflow.com/questions/43080678/join-query-in-hanami-model

Reference to #343

@davydovanton
Copy link
Member Author

/cc @hanami/core

@alvir
Copy link

alvir commented May 9, 2017

I was confused with query documentation in guides. I think It will be helpful to add info about rom-sql and Sequel.

@mereghost
Copy link
Member

Some guides would be nice, specially to the features where we meddle with rom (associations and the like).

Covering all the queries would make our docs coupled to rom's docs, so it would be better to point users to rom docs.

@cveneziani
Copy link
Contributor

What about this issue now, since Pull Request #386 has been merged?

@davydovanton
Copy link
Member Author

@cveneziani hey! you can take my old PR and update it if you want #344 :)

@cveneziani
Copy link
Contributor

Well, as @mereghost mentioned. Shall we copy the doc from ROM or just point out to ROM doc? And if we copy, where shall we stop?

What's you point of view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants