Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow source control of public/404,500.html via gitignore #286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow source control of public/404,500.html via gitignore #286

wants to merge 2 commits into from

Conversation

kyleplump
Copy link
Contributor

@kyleplump kyleplump commented Jan 9, 2025 •
edited by timriley
Loading

Closes #285

When generating the .gitignore file on hanami new, allow the public/404.html and public/500.html files, while keeping the rest of public/ ignored.

please let me know if you'd like to see any changes. thanks!

@timriley timriley changed the title whitelist public/404,500.html in gitignore Allow source control of public/404,500.html via gitignore Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated .gitignore should explicitly allow public/{404,500}.html
1 participant
@kyleplump