Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull in buildImage package from nixpkgs for docker module evaluation #3

Open
hall opened this issue Aug 28, 2022 · 0 comments
Open
Labels
help wanted Extra attention is needed

Comments

@hall
Copy link
Owner

hall commented Aug 28, 2022

In order to evaluate the docker module (for generating documentation), I had to expand the default value (in e3127e8) of image.tag and image.name to include an empty string if config.image is null. It's likely that pkgs.dockerTools.buildImage (where the imageName and imageTag attrs are built) needs to be referenced in some way to avoid config.image being null.

I'm not confident at this time whether that's actually true but I'm creating this issue to not lose track of the (potential) problem.

@hall hall added the help wanted Extra attention is needed label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant