Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 11 does not render #411

Open
RaymondBalise opened this issue Mar 8, 2025 · 0 comments
Open

Chapter 11 does not render #411

RaymondBalise opened this issue Mar 8, 2025 · 0 comments

Comments

@RaymondBalise
Copy link

The ggbuild() function is preventing chapter 11 from rendering because it is referencing ggplot2:::scales_transform_df and it does not exist. I poked around in the git history for {ggplot2} and it appeared in these two commits: 969cde2bf541888ea6a8fe63d2e8edf662fb01c2 and 83697ed0413ab1d0c07277f53e43017de184aac8. Those were made around v3.4.4. I can see from plot-build.R in the ggplot2 repo, that the function (and a pile of others) were eventually renamed to drop the scales_ prefix in: 7d8c52b346e4c595d20cbd43ff300f559f569586

I chased down the rabbit hole of making ggbuild() from interals_ggbuild.R in the book repo match ggplot_build.ggplot() in the ggplot2 (3.5.1) version of plot-build.R until I ran into this line

plot$guides <- plot$guides$build(npscales, plot$layers, plot$labels, data, plot$theme)

throwing:

Error in build(..., self = self) : unused argument (list())

and I gave up....

I (obviously) would love to see the final version of chapter 11. If I can help please drop me a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant