Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CSS files (by reading the removeCombined property) #205

Open
sp00m opened this issue Dec 16, 2015 · 3 comments
Open

Removing CSS files (by reading the removeCombined property) #205

sp00m opened this issue Dec 16, 2015 · 3 comments

Comments

@sp00m
Copy link

sp00m commented Dec 16, 2015

After having optimized my main module, the CSS is added by JavaScript at runtime, by appending a style tag to the head tag. This is done in the main.js output file.

The CSS files that were combined aren't used anymore, so it could be interesting to remove them automatically. Maybe the removeCombined property could be read.

@ffflabs
Copy link

ffflabs commented Dec 16, 2015

I did a quick POC and it seems to work fine #206.

Perhaps we should consider some edge cases, like if a CSS file is required by more than one build target.

Also, for the removal to actually happen, the optimizer should be configured with attributes config.removeCombined = true and config.buildCSS != false.

@ischrei
Copy link

ischrei commented Nov 30, 2016

Hi,
Any update on this issue please?
I see it is opened for a while already..
Thanks!

@alundiak
Copy link
Collaborator

alundiak commented Feb 18, 2017

@ischrei @amenadiel @sp00m I will work on reviewing PRs, so if the issue still relevant, please let me know. And see my PR #206 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants